From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965518AbcKDSku (ORCPT ); Fri, 4 Nov 2016 14:40:50 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41570 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964914AbcKDSks (ORCPT ); Fri, 4 Nov 2016 14:40:48 -0400 Date: Fri, 04 Nov 2016 14:40:46 -0400 (EDT) Message-Id: <20161104.144046.144416497334140758.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net-next v2 00/11] net: dsa: mv88e6xxx: refine port operations From: David Miller In-Reply-To: <20161104022336.14273-1-vivien.didelot@savoirfairelinux.com> References: <20161104022336.14273-1-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 04 Nov 2016 10:41:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot Date: Fri, 4 Nov 2016 03:23:25 +0100 > The Marvell chips have one internal SMI device per port, containing a > set of registers used to configure a port's link, STP state, default > VLAN or addresses database, etc. > > This patchset creates port files to implement the port operations as > described in datasheets, and extend the chip ops structure with them. > > Patches 1 to 6 implement accessors for port's STP state, port based VLAN > map, default FID, default VID, and 802.1Q mode. > > Patches 7 to 11 implement the port's MAC setup of link state, duplex > mode, RGMII delay and speed, all accessed through port's register 0x01. > > The new port's MAC setup code is used to re-implement the adjust_link > code and correctly force the link down before changing any of the MAC > settings, as requested by the datasheets. > > The port's MAC accessors use values compatible with struct phy_device > (e.g. DUPLEX_FULL) and extend them when needed (e.g. SPEED_MAX). > > Changes in v2: > > - Strictly use new _UNFORCED values instead of re-using _UNKNOWN ones. Series applied, thanks Vivien.