From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761292AbcKDKSK (ORCPT ); Fri, 4 Nov 2016 06:18:10 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34827 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761189AbcKDKSE (ORCPT ); Fri, 4 Nov 2016 06:18:04 -0400 Date: Fri, 4 Nov 2016 18:17:54 +0800 From: Eva Rachel Retuya To: Matt Ranostay Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, Linux Kernel , Lars-Peter Clausen , Michael.Hennerich@analog.com, Jonathan Cameron , knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org Subject: Re: [PATCH 1/6] staging: iio: set proper supply name to devm_regulator_get() Message-ID: <20161104101753.GA17800@Socrates-DK> Mail-Followup-To: Matt Ranostay , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, Linux Kernel , Lars-Peter Clausen , Michael.Hennerich@analog.com, Jonathan Cameron , knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org References: <1477933475-21914-1-git-send-email-eraretuya@gmail.com> <1477933475-21914-2-git-send-email-eraretuya@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Matt, On Mon, Oct 31, 2016 at 09:03:57PM -0700, Matt Ranostay wrote: > On Mon, Oct 31, 2016 at 10:04 AM, Eva Rachel Retuya wrote: > > The name passed to devm_regulator_get() should match the name of the > > supply as specified in the device datasheet. This makes it clear what > > power supply is being referred to in case of presence of other > > regulators. > > > > Currently, the supply name specified on the affected devices is 'vcc'. > > Use lowercase version of the datasheet name to specify the supply > > voltage. > > > > Aren't we possibly breaking current device tree definitions that > people may have? We should still check the old name after the new > datasheet name in my opinion. > I was told it was okay to rename those IIO drivers under staging. I also double-checked if there are available DT bindings for these drivers and found none. Thanks, Eva > > Suggested-by: Lars-Peter Clausen > > Signed-off-by: Eva Rachel Retuya > > --- > > drivers/staging/iio/adc/ad7192.c | 2 +- > > drivers/staging/iio/adc/ad7780.c | 2 +- > > drivers/staging/iio/frequency/ad9832.c | 2 +- > > drivers/staging/iio/frequency/ad9834.c | 2 +- > > drivers/staging/iio/impedance-analyzer/ad5933.c | 2 +- > > 5 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > > index bfa12ce..41fb32d 100644 > > --- a/drivers/staging/iio/adc/ad7192.c > > +++ b/drivers/staging/iio/adc/ad7192.c > > @@ -633,7 +633,7 @@ static int ad7192_probe(struct spi_device *spi) > > > > st = iio_priv(indio_dev); > > > > - st->reg = devm_regulator_get(&spi->dev, "vcc"); > > + st->reg = devm_regulator_get(&spi->dev, "avdd"); > > if (!IS_ERR(st->reg)) { > > ret = regulator_enable(st->reg); > > if (ret) > > diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c > > index c9a0c2a..a88236e 100644 > > --- a/drivers/staging/iio/adc/ad7780.c > > +++ b/drivers/staging/iio/adc/ad7780.c > > @@ -173,7 +173,7 @@ static int ad7780_probe(struct spi_device *spi) > > > > ad_sd_init(&st->sd, indio_dev, spi, &ad7780_sigma_delta_info); > > > > - st->reg = devm_regulator_get(&spi->dev, "vcc"); > > + st->reg = devm_regulator_get(&spi->dev, "avdd"); > > if (!IS_ERR(st->reg)) { > > ret = regulator_enable(st->reg); > > if (ret) > > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c > > index 358400b..744c8ee 100644 > > --- a/drivers/staging/iio/frequency/ad9832.c > > +++ b/drivers/staging/iio/frequency/ad9832.c > > @@ -212,7 +212,7 @@ static int ad9832_probe(struct spi_device *spi) > > return -ENODEV; > > } > > > > - reg = devm_regulator_get(&spi->dev, "vcc"); > > + reg = devm_regulator_get(&spi->dev, "avdd"); > > if (!IS_ERR(reg)) { > > ret = regulator_enable(reg); > > if (ret) > > diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c > > index 6366216..ca3cea6 100644 > > --- a/drivers/staging/iio/frequency/ad9834.c > > +++ b/drivers/staging/iio/frequency/ad9834.c > > @@ -329,7 +329,7 @@ static int ad9834_probe(struct spi_device *spi) > > return -ENODEV; > > } > > > > - reg = devm_regulator_get(&spi->dev, "vcc"); > > + reg = devm_regulator_get(&spi->dev, "avdd"); > > if (!IS_ERR(reg)) { > > ret = regulator_enable(reg); > > if (ret) > > diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c > > index 5eecf1c..62f61bc 100644 > > --- a/drivers/staging/iio/impedance-analyzer/ad5933.c > > +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c > > @@ -723,7 +723,7 @@ static int ad5933_probe(struct i2c_client *client, > > if (!pdata) > > pdata = &ad5933_default_pdata; > > > > - st->reg = devm_regulator_get(&client->dev, "vcc"); > > + st->reg = devm_regulator_get(&client->dev, "vdd"); > > if (!IS_ERR(st->reg)) { > > ret = regulator_enable(st->reg); > > if (ret) > > -- > > 2.7.4 > >