From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935365AbcKDPGm (ORCPT <rfc822;w@1wt.eu>);
        Fri, 4 Nov 2016 11:06:42 -0400
Received: from mail.skyhub.de ([78.46.96.112]:51710 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932271AbcKDPGk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 4 Nov 2016 11:06:40 -0400
Date: Fri, 4 Nov 2016 16:06:37 +0100
From: Borislav Petkov <bp@alien8.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: He Chen <he.chen@linux.intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, Luwei Kang <luwei.kang@intel.com>,
        Piotr Luc <Piotr.Luc@intel.com>
Subject: Re: [PATCH v3] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS
 features to kvm guest
Message-ID: <20161104150637.ejyxq5rfwcwggo3q@pd.tnic>
References: <1478243239-15586-1-git-send-email-he.chen@linux.intel.com>
 <20161104105235.qbqvmsv4ikajvjtu@pd.tnic>
 <ecdc20d5-e5c2-cab7-2973-39c811cac42c@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ecdc20d5-e5c2-cab7-2973-39c811cac42c@redhat.com>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 04, 2016 at 03:53:02PM +0100, Paolo Bonzini wrote:
> > The modification to scattered et al without the kvm use should be a
> > separate patch.
> 
> With no usage?  Sounds like a good use of Acked-by. :)

I don't understand what do you mean here?

> >> +u32 get_scattered_cpuid_leaf(unsigned int level, unsigned int sub_leaf,
> >> +			     enum cpuid_regs_idx reg)
> > 
> > Align arguments on the opening brace.
> 
> They are aligned.

Right you are. I need to look into why those spaces get eaten in vim.
Looks like something is replacing 4 spaces with a single one...

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.