From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935869AbcKDPcw (ORCPT ); Fri, 4 Nov 2016 11:32:52 -0400 Received: from mga11.intel.com ([192.55.52.93]:47346 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932150AbcKDPcv (ORCPT ); Fri, 4 Nov 2016 11:32:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,443,1473145200"; d="scan'208";a="897758713" Date: Fri, 4 Nov 2016 17:28:21 +0200 From: Mika Westerberg To: Linus Walleij Cc: Christian Steiner , Heikki Krogerus , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] pinctrl: cherryview: Serialize register access in suspend and resume hooks Message-ID: <20161104152821.GS1436@lahna.fi.intel.com> References: <20161031145734.193016-1-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 04, 2016 at 04:15:59PM +0100, Linus Walleij wrote: > On Fri, Nov 4, 2016 at 4:12 PM, Linus Walleij wrote: > > On Mon, Oct 31, 2016 at 3:57 PM, Mika Westerberg > > wrote: > > > >> If async suspend is enabled, the driver may access registers concurrently > >> with another instance which may fail because of the bug in Cherryview GPIO > >> hardware. Prevent this by taking the shared lock while accessing the > >> hardware in suspend and resume hooks. > >> > >> Signed-off-by: Mika Westerberg > > > > Patch applied. > > Mika should this and patch 2/3 be tagged for stable? Yes, I think they should.