From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756761AbcKDP54 (ORCPT ); Fri, 4 Nov 2016 11:57:56 -0400 Received: from mail.skyhub.de ([78.46.96.112]:34082 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756534AbcKDP5y (ORCPT ); Fri, 4 Nov 2016 11:57:54 -0400 Date: Fri, 4 Nov 2016 16:57:52 +0100 From: Borislav Petkov To: Paolo Bonzini Cc: He Chen , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Luwei Kang , Piotr Luc Subject: Re: [PATCH v3] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS features to kvm guest Message-ID: <20161104155752.e6gf7hev3tklbw6m@pd.tnic> References: <1478243239-15586-1-git-send-email-he.chen@linux.intel.com> <20161104105235.qbqvmsv4ikajvjtu@pd.tnic> <20161104150637.ejyxq5rfwcwggo3q@pd.tnic> <39d57b21-671d-8c25-8d25-ba2cfd0dc4f9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <39d57b21-671d-8c25-8d25-ba2cfd0dc4f9@redhat.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 04, 2016 at 04:13:24PM +0100, Paolo Bonzini wrote: > I mean that the changes to scattered.c are small, so it makes no sense > to split them. With an Acked-by I could simply take the patch into my > tree. On no, it is not about the size or which tree it goes thru - rather that having stuff separated conceptually makes the patches much more clear. The patch order would be * modify scattered.c to return leaf * add user of new function which also makes review almost trivial. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.