From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752286AbcKGJ5u (ORCPT ); Mon, 7 Nov 2016 04:57:50 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34591 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbcKGJ5r (ORCPT ); Mon, 7 Nov 2016 04:57:47 -0500 Date: Mon, 7 Nov 2016 10:57:44 +0100 From: Corentin Labbe To: minyard@acm.org Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [BUG] ipmi: NULL device printing in check_set_rcv_irq() Message-ID: <20161107095744.GA20037@Red> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello On one of my servers I got this line in dmesg (NULL device *): The BMC does not support setting the recv irq bit, compensating, but the BMC needs to be fixed. This printing is done via a dev_warn(smi_info->dev,) in drivers/char/ipmi/ipmi_si_intf.c:check_clr_rcv_irq() but smi_info->dev is set only latter in try_smi_init(). I do not know which way is better to fix it, either move the code block which register the device before check_for_broken_irqs(), or perhaps replace dev_warn by pr_warn. Regards Corentin Labbe