From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752242AbcKGKa4 (ORCPT ); Mon, 7 Nov 2016 05:30:56 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44380 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbcKGKay (ORCPT ); Mon, 7 Nov 2016 05:30:54 -0500 Date: Mon, 7 Nov 2016 11:31:03 +0100 From: Greg KH To: Shiva Kerdel Cc: German.Rivera@freescale.com, devel@driverdev.osuosl.org, nipun.gupta@nxp.com, stuart.yoder@nxp.com, linux-kernel@vger.kernel.org, german.rivera@nxp.com, treding@nvidia.com, bharat.bhushan@nxp.com, itai.katz@nxp.com Subject: Re: [PATCH] Staging: fsl-mc: Changed allocation types into the types that the kernel prefers Message-ID: <20161107103103.GA26135@kroah.com> References: <20161106231201.15582-1-shiva@exdev.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161106231201.15582-1-shiva@exdev.nl> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2016 at 12:12:01AM +0100, Shiva Kerdel wrote: > Fixed reports from checkpatch that pointed out that the code was not > using the preferred types of the kernel. > > Signed-off-by: Shiva Kerdel > --- > drivers/staging/fsl-mc/bus/dpmcp.h | 80 ++++++++++++++++----------------- > drivers/staging/fsl-mc/include/mc-bus.h | 4 +- > drivers/staging/fsl-mc/include/mc.h | 2 +- > 3 files changed, 43 insertions(+), 43 deletions(-) > > diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/staging/fsl-mc/bus/dpmcp.h > index fe79d4d..684c5b5 100644 > --- a/drivers/staging/fsl-mc/bus/dpmcp.h > +++ b/drivers/staging/fsl-mc/bus/dpmcp.h > @@ -39,7 +39,7 @@ > struct fsl_mc_io; > > int dpmcp_open(struct fsl_mc_io *mc_io, > - uint32_t cmd_flags, > + u32 cmd_flags, > int dpmcp_id, > uint16_t *token); > > @@ -47,7 +47,7 @@ int dpmcp_open(struct fsl_mc_io *mc_io, > #define DPMCP_GET_PORTAL_ID_FROM_POOL (-1) > > int dpmcp_close(struct fsl_mc_io *mc_io, > - uint32_t cmd_flags, > + u32 cmd_flags, > uint16_t token); > > /** > @@ -60,16 +60,16 @@ struct dpmcp_cfg { > }; > > int dpmcp_create(struct fsl_mc_io *mc_io, > - uint32_t cmd_flags, > + u32 cmd_flags, > const struct dpmcp_cfg *cfg, > - uint16_t *token); > + uint16_t *token); Why did you change the indentation of this line? Please only do one type of thing, like change the unit32_t types to u32, in one patch, then do the uint64_t, and then, you forgot the uint16_t changes :( Please fix up and make a patch series for this. thanks, greg k-h