linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4] media: et8ek8: add device tree binding documentation
@ 2016-10-23 19:17 Pavel Machek
  2016-10-23 20:06 ` Sakari Ailus
  2016-10-30 20:41 ` Rob Herring
  0 siblings, 2 replies; 14+ messages in thread
From: Pavel Machek @ 2016-10-23 19:17 UTC (permalink / raw)
  To: ivo.g.dimitrov.75, sakari.ailus, sre, pali.rohar, linux-media,
	robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	mchehab, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1956 bytes --]


Add device tree binding documentation for toshiba et8ek8 sensor.

Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>

---

diff from v3: explain what clock-frequency means


diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
new file mode 100644
index 0000000..54863cf
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
@@ -0,0 +1,51 @@
+Toshiba et8ek8 5MP sensor
+
+Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
+
+More detailed documentation can be found in
+Documentation/devicetree/bindings/media/video-interfaces.txt .
+
+
+Mandatory properties
+--------------------
+
+- compatible: "toshiba,et8ek8"
+- reg: I2C address (0x3e, or an alternative address)
+- vana-supply: Analogue voltage supply (VANA), 2.8 volts
+- clocks: External clock to the sensor
+- clock-frequency: Frequency of the external clock to the sensor. Camera
+  driver will set this frequency on the external clock.
+- reset-gpios: XSHUTDOWN GPIO
+
+
+Endpoint node mandatory properties
+----------------------------------
+
+- remote-endpoint: A phandle to the bus receiver's endpoint node.
+
+Endpoint node optional properties
+----------------------------------
+
+- clock-lanes: <0>
+- data-lanes: <1..n>
+
+Example
+-------
+
+&i2c3 {
+	clock-frequency = <400000>;
+
+	cam1: camera@3e {
+		compatible = "toshiba,et8ek8";
+		reg = <0x3e>;
+		vana-supply = <&vaux4>;
+		clocks = <&isp 0>;
+		clock-frequency = <9600000>;
+		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
+		port {
+			csi_cam1: endpoint {
+				remote-endpoint = <&csi_out1>;
+			};
+		};
+	};
+};

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v4] media: et8ek8: add device tree binding documentation
  2016-10-23 19:17 [PATCH v4] media: et8ek8: add device tree binding documentation Pavel Machek
@ 2016-10-23 20:06 ` Sakari Ailus
  2016-10-30 20:41 ` Rob Herring
  1 sibling, 0 replies; 14+ messages in thread
From: Sakari Ailus @ 2016-10-23 20:06 UTC (permalink / raw)
  To: Pavel Machek
  Cc: ivo.g.dimitrov.75, sre, pali.rohar, linux-media, robh+dt,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

Hi Pavel,

On Sun, Oct 23, 2016 at 09:17:06PM +0200, Pavel Machek wrote:
> 
> Add device tree binding documentation for toshiba et8ek8 sensor.

How about the et8ek8 driver itself? And the N900 DT snippet? What's their
status?

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v4] media: et8ek8: add device tree binding documentation
  2016-10-23 19:17 [PATCH v4] media: et8ek8: add device tree binding documentation Pavel Machek
  2016-10-23 20:06 ` Sakari Ailus
@ 2016-10-30 20:41 ` Rob Herring
  2016-10-31 22:47   ` Sakari Ailus
                     ` (2 more replies)
  1 sibling, 3 replies; 14+ messages in thread
From: Rob Herring @ 2016-10-30 20:41 UTC (permalink / raw)
  To: Pavel Machek
  Cc: ivo.g.dimitrov.75, sakari.ailus, sre, pali.rohar, linux-media,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

On Sun, Oct 23, 2016 at 09:17:06PM +0200, Pavel Machek wrote:
> 
> Add device tree binding documentation for toshiba et8ek8 sensor.
> 
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> ---
> 
> diff from v3: explain what clock-frequency means
> 
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> new file mode 100644
> index 0000000..54863cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> @@ -0,0 +1,51 @@
> +Toshiba et8ek8 5MP sensor
> +
> +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
> +
> +More detailed documentation can be found in
> +Documentation/devicetree/bindings/media/video-interfaces.txt .
> +
> +
> +Mandatory properties
> +--------------------
> +
> +- compatible: "toshiba,et8ek8"
> +- reg: I2C address (0x3e, or an alternative address)
> +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
> +- clocks: External clock to the sensor
> +- clock-frequency: Frequency of the external clock to the sensor. Camera
> +  driver will set this frequency on the external clock.

This is fine if the frequency is fixed (e.g. an oscillator), but you 
should use the clock binding if clocks are programable.

> +- reset-gpios: XSHUTDOWN GPIO

Please state what the active polarity is.

> +
> +
> +Endpoint node mandatory properties
> +----------------------------------
> +
> +- remote-endpoint: A phandle to the bus receiver's endpoint node.
> +
> +Endpoint node optional properties
> +----------------------------------
> +
> +- clock-lanes: <0>
> +- data-lanes: <1..n>
> +
> +Example
> +-------
> +
> +&i2c3 {
> +	clock-frequency = <400000>;
> +
> +	cam1: camera@3e {
> +		compatible = "toshiba,et8ek8";
> +		reg = <0x3e>;
> +		vana-supply = <&vaux4>;
> +		clocks = <&isp 0>;
> +		clock-frequency = <9600000>;
> +		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
> +		port {
> +			csi_cam1: endpoint {
> +				remote-endpoint = <&csi_out1>;
> +			};
> +		};
> +	};
> +};
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v4] media: et8ek8: add device tree binding documentation
  2016-10-30 20:41 ` Rob Herring
@ 2016-10-31 22:47   ` Sakari Ailus
  2016-11-03 12:47   ` Pavel Machek
  2016-11-07 10:46   ` [PATCH v5] " Pavel Machek
  2 siblings, 0 replies; 14+ messages in thread
From: Sakari Ailus @ 2016-10-31 22:47 UTC (permalink / raw)
  To: Rob Herring
  Cc: Pavel Machek, ivo.g.dimitrov.75, sre, pali.rohar, linux-media,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

Hi Rob and Pavel,

On Sun, Oct 30, 2016 at 03:41:34PM -0500, Rob Herring wrote:
> On Sun, Oct 23, 2016 at 09:17:06PM +0200, Pavel Machek wrote:
> > 
> > Add device tree binding documentation for toshiba et8ek8 sensor.
> > 
> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > ---
> > 
> > diff from v3: explain what clock-frequency means
> > 
> > 
> > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> > new file mode 100644
> > index 0000000..54863cf
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> > @@ -0,0 +1,51 @@
> > +Toshiba et8ek8 5MP sensor
> > +
> > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
> > +
> > +More detailed documentation can be found in
> > +Documentation/devicetree/bindings/media/video-interfaces.txt .
> > +
> > +
> > +Mandatory properties
> > +--------------------
> > +
> > +- compatible: "toshiba,et8ek8"
> > +- reg: I2C address (0x3e, or an alternative address)
> > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
> > +- clocks: External clock to the sensor
> > +- clock-frequency: Frequency of the external clock to the sensor. Camera
> > +  driver will set this frequency on the external clock.
> 
> This is fine if the frequency is fixed (e.g. an oscillator), but you 
> should use the clock binding if clocks are programable.

We've discussed the matter here (v3):

<URL:http://www.spinics.net/lists/linux-media/msg101210.html>

<URL:http://www.spinics.net/lists/linux-media/msg101233.html>

Pavel, could you add to the desciption e.g.:

"The clock frequency is a pre-determined frequency known to be suitable to
the board."

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v4] media: et8ek8: add device tree binding documentation
  2016-10-30 20:41 ` Rob Herring
  2016-10-31 22:47   ` Sakari Ailus
@ 2016-11-03 12:47   ` Pavel Machek
  2016-11-03 22:20     ` Sakari Ailus
  2016-11-07 10:46   ` [PATCH v5] " Pavel Machek
  2 siblings, 1 reply; 14+ messages in thread
From: Pavel Machek @ 2016-11-03 12:47 UTC (permalink / raw)
  To: Rob Herring
  Cc: ivo.g.dimitrov.75, sakari.ailus, sre, pali.rohar, linux-media,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

Hi!

> > +Mandatory properties
> > +--------------------
> > +
> > +- compatible: "toshiba,et8ek8"
> > +- reg: I2C address (0x3e, or an alternative address)
> > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
> > +- clocks: External clock to the sensor
> > +- clock-frequency: Frequency of the external clock to the sensor. Camera
> > +  driver will set this frequency on the external clock.
> 
> This is fine if the frequency is fixed (e.g. an oscillator), but you 
> should use the clock binding if clocks are programable.

It is fixed. So I assume this can stay as is? Or do you want me to add
"The clock frequency is a pre-determined frequency known to be
suitable to the board." as Sakari suggests?

> > +- reset-gpios: XSHUTDOWN GPIO
> 
> Please state what the active polarity is.

As in "This gpio will be set to 1 when the chip is powered." ?

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v4] media: et8ek8: add device tree binding documentation
  2016-11-03 12:47   ` Pavel Machek
@ 2016-11-03 22:20     ` Sakari Ailus
  2016-11-07 10:36       ` Pavel Machek
  0 siblings, 1 reply; 14+ messages in thread
From: Sakari Ailus @ 2016-11-03 22:20 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Rob Herring, ivo.g.dimitrov.75, sre, pali.rohar, linux-media,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

Hi Pavel and Rob,

On Thu, Nov 03, 2016 at 01:47:49PM +0100, Pavel Machek wrote:
> Hi!
> 
> > > +Mandatory properties
> > > +--------------------
> > > +
> > > +- compatible: "toshiba,et8ek8"
> > > +- reg: I2C address (0x3e, or an alternative address)
> > > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
> > > +- clocks: External clock to the sensor
> > > +- clock-frequency: Frequency of the external clock to the sensor. Camera
> > > +  driver will set this frequency on the external clock.
> > 
> > This is fine if the frequency is fixed (e.g. an oscillator), but you 
> > should use the clock binding if clocks are programable.
> 
> It is fixed. So I assume this can stay as is? Or do you want me to add
> "The clock frequency is a pre-determined frequency known to be
> suitable to the board." as Sakari suggests?
> 
> > > +- reset-gpios: XSHUTDOWN GPIO
> > 
> > Please state what the active polarity is.
> 
> As in "This gpio will be set to 1 when the chip is powered." ?

How about:

"The XSHUTDOWN signal is active high. The sensor is in hardware standby
mode when the signal is in low state."

These bindings start looking more precise than the smiapp ones. :-)

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v4] media: et8ek8: add device tree binding documentation
  2016-11-03 22:20     ` Sakari Ailus
@ 2016-11-07 10:36       ` Pavel Machek
  0 siblings, 0 replies; 14+ messages in thread
From: Pavel Machek @ 2016-11-07 10:36 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: Rob Herring, ivo.g.dimitrov.75, sre, pali.rohar, linux-media,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]

On Fri 2016-11-04 00:20:14, Sakari Ailus wrote:
> Hi Pavel and Rob,
> 
> On Thu, Nov 03, 2016 at 01:47:49PM +0100, Pavel Machek wrote:
> > Hi!
> > 
> > > > +Mandatory properties
> > > > +--------------------
> > > > +
> > > > +- compatible: "toshiba,et8ek8"
> > > > +- reg: I2C address (0x3e, or an alternative address)
> > > > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
> > > > +- clocks: External clock to the sensor
> > > > +- clock-frequency: Frequency of the external clock to the sensor. Camera
> > > > +  driver will set this frequency on the external clock.
> > > 
> > > This is fine if the frequency is fixed (e.g. an oscillator), but you 
> > > should use the clock binding if clocks are programable.
> > 
> > It is fixed. So I assume this can stay as is? Or do you want me to add
> > "The clock frequency is a pre-determined frequency known to be
> > suitable to the board." as Sakari suggests?

Rob?
								Pavel

> > > > +- reset-gpios: XSHUTDOWN GPIO
> > > 
> > > Please state what the active polarity is.
> > 
> > As in "This gpio will be set to 1 when the chip is powered." ?
> 
> How about:
> 
> "The XSHUTDOWN signal is active high. The sensor is in hardware standby
> mode when the signal is in low state."
> 
> These bindings start looking more precise than the smiapp ones. :-)
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v5] media: et8ek8: add device tree binding documentation
  2016-10-30 20:41 ` Rob Herring
  2016-10-31 22:47   ` Sakari Ailus
  2016-11-03 12:47   ` Pavel Machek
@ 2016-11-07 10:46   ` Pavel Machek
  2016-11-11 12:17     ` Pavel Machek
                       ` (2 more replies)
  2 siblings, 3 replies; 14+ messages in thread
From: Pavel Machek @ 2016-11-07 10:46 UTC (permalink / raw)
  To: Rob Herring
  Cc: ivo.g.dimitrov.75, sakari.ailus, sre, pali.rohar, linux-media,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]

Add device tree binding documentation for toshiba et8ek8 sensor.

Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
new file mode 100644
index 0000000..b03b21d
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
@@ -0,0 +1,53 @@
+Toshiba et8ek8 5MP sensor
+
+Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
+
+More detailed documentation can be found in
+Documentation/devicetree/bindings/media/video-interfaces.txt .
+
+
+Mandatory properties
+--------------------
+
+- compatible: "toshiba,et8ek8"
+- reg: I2C address (0x3e, or an alternative address)
+- vana-supply: Analogue voltage supply (VANA), 2.8 volts
+- clocks: External clock to the sensor
+- clock-frequency: Frequency of the external clock to the sensor. Camera
+  driver will set this frequency on the external clock. The clock frequency is
+  a pre-determined frequency known to be suitable to the board.
+- reset-gpios: XSHUTDOWN GPIO. The XSHUTDOWN signal is active high. The sensor
+  is in hardware standby mode when the signal is in low state.
+
+
+Endpoint node mandatory properties
+----------------------------------
+
+- remote-endpoint: A phandle to the bus receiver's endpoint node.
+
+Endpoint node optional properties
+----------------------------------
+
+- clock-lanes: <0>
+- data-lanes: <1..n>
+
+Example
+-------
+
+&i2c3 {
+	clock-frequency = <400000>;
+
+	cam1: camera@3e {
+		compatible = "toshiba,et8ek8";
+		reg = <0x3e>;
+		vana-supply = <&vaux4>;
+		clocks = <&isp 0>;
+		clock-frequency = <9600000>;
+		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
+		port {
+			csi_cam1: endpoint {
+				remote-endpoint = <&csi_out1>;
+			};
+		};
+	};
+};


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v5] media: et8ek8: add device tree binding documentation
  2016-11-07 10:46   ` [PATCH v5] " Pavel Machek
@ 2016-11-11 12:17     ` Pavel Machek
  2016-11-14 16:20     ` Rob Herring
  2016-11-14 18:30     ` [PATCH v6] " Pavel Machek
  2 siblings, 0 replies; 14+ messages in thread
From: Pavel Machek @ 2016-11-11 12:17 UTC (permalink / raw)
  To: Rob Herring
  Cc: ivo.g.dimitrov.75, sakari.ailus, sre, pali.rohar, linux-media,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

On Mon 2016-11-07 11:46:48, Pavel Machek wrote:
> Add device tree binding documentation for toshiba et8ek8 sensor.
> 
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Rob, can we get an ack here?

Thanks,
							Pavel

> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> new file mode 100644
> index 0000000..b03b21d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> @@ -0,0 +1,53 @@
> +Toshiba et8ek8 5MP sensor
> +
> +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
> +
> +More detailed documentation can be found in
> +Documentation/devicetree/bindings/media/video-interfaces.txt .
> +
> +
> +Mandatory properties
> +--------------------
> +
> +- compatible: "toshiba,et8ek8"
> +- reg: I2C address (0x3e, or an alternative address)
> +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
> +- clocks: External clock to the sensor
> +- clock-frequency: Frequency of the external clock to the sensor. Camera
> +  driver will set this frequency on the external clock. The clock frequency is
> +  a pre-determined frequency known to be suitable to the board.
> +- reset-gpios: XSHUTDOWN GPIO. The XSHUTDOWN signal is active high. The sensor
> +  is in hardware standby mode when the signal is in low state.
> +
> +
> +Endpoint node mandatory properties
> +----------------------------------
> +
> +- remote-endpoint: A phandle to the bus receiver's endpoint node.
> +
> +Endpoint node optional properties
> +----------------------------------
> +
> +- clock-lanes: <0>
> +- data-lanes: <1..n>
> +
> +Example
> +-------
> +
> +&i2c3 {
> +	clock-frequency = <400000>;
> +
> +	cam1: camera@3e {
> +		compatible = "toshiba,et8ek8";
> +		reg = <0x3e>;
> +		vana-supply = <&vaux4>;
> +		clocks = <&isp 0>;
> +		clock-frequency = <9600000>;
> +		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
> +		port {
> +			csi_cam1: endpoint {
> +				remote-endpoint = <&csi_out1>;
> +			};
> +		};
> +	};
> +};
> 
> 



-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v5] media: et8ek8: add device tree binding documentation
  2016-11-07 10:46   ` [PATCH v5] " Pavel Machek
  2016-11-11 12:17     ` Pavel Machek
@ 2016-11-14 16:20     ` Rob Herring
  2016-11-14 18:30     ` [PATCH v6] " Pavel Machek
  2 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2016-11-14 16:20 UTC (permalink / raw)
  To: Pavel Machek
  Cc: ivo.g.dimitrov.75, sakari.ailus, sre, pali.rohar, linux-media,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

On Mon, Nov 07, 2016 at 11:46:48AM +0100, Pavel Machek wrote:
> Add device tree binding documentation for toshiba et8ek8 sensor.
> 
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> new file mode 100644
> index 0000000..b03b21d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> @@ -0,0 +1,53 @@
> +Toshiba et8ek8 5MP sensor
> +
> +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
> +
> +More detailed documentation can be found in
> +Documentation/devicetree/bindings/media/video-interfaces.txt .
> +
> +
> +Mandatory properties
> +--------------------
> +
> +- compatible: "toshiba,et8ek8"
> +- reg: I2C address (0x3e, or an alternative address)
> +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
> +- clocks: External clock to the sensor
> +- clock-frequency: Frequency of the external clock to the sensor. Camera
> +  driver will set this frequency on the external clock. The clock frequency is
> +  a pre-determined frequency known to be suitable to the board.
> +- reset-gpios: XSHUTDOWN GPIO. The XSHUTDOWN signal is active high. The sensor
> +  is in hardware standby mode when the signal is in low state.

Sounds like active low to me. "Active" means when is the defined 
function of the pin enabled, not when is the chip active/enabled. So in 
this case reset or shutdown is active when low.

Rob

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v6] media: et8ek8: add device tree binding documentation
  2016-11-07 10:46   ` [PATCH v5] " Pavel Machek
  2016-11-11 12:17     ` Pavel Machek
  2016-11-14 16:20     ` Rob Herring
@ 2016-11-14 18:30     ` Pavel Machek
  2016-11-14 18:39       ` Rob Herring
  2016-12-20 13:05       ` Sakari Ailus
  2 siblings, 2 replies; 14+ messages in thread
From: Pavel Machek @ 2016-11-14 18:30 UTC (permalink / raw)
  To: Rob Herring
  Cc: ivo.g.dimitrov.75, sakari.ailus, sre, pali.rohar, linux-media,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2159 bytes --]

Add device tree binding documentation for toshiba et8ek8 sensor.

Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>

---

v6: added missing article, fixed signal polarity.

diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
new file mode 100644
index 0000000..b03b21d
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
@@ -0,0 +1,53 @@
+Toshiba et8ek8 5MP sensor
+
+Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
+
+More detailed documentation can be found in
+Documentation/devicetree/bindings/media/video-interfaces.txt .
+
+
+Mandatory properties
+--------------------
+
+- compatible: "toshiba,et8ek8"
+- reg: I2C address (0x3e, or an alternative address)
+- vana-supply: Analogue voltage supply (VANA), 2.8 volts
+- clocks: External clock to the sensor
+- clock-frequency: Frequency of the external clock to the sensor. Camera
+  driver will set this frequency on the external clock. The clock frequency is
+  a pre-determined frequency known to be suitable to the board.
+- reset-gpios: XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
+  is in hardware standby mode when the signal is in the low state.
+
+
+Endpoint node mandatory properties
+----------------------------------
+
+- remote-endpoint: A phandle to the bus receiver's endpoint node.
+
+Endpoint node optional properties
+----------------------------------
+
+- clock-lanes: <0>
+- data-lanes: <1..n>
+
+Example
+-------
+
+&i2c3 {
+	clock-frequency = <400000>;
+
+	cam1: camera@3e {
+		compatible = "toshiba,et8ek8";
+		reg = <0x3e>;
+		vana-supply = <&vaux4>;
+		clocks = <&isp 0>;
+		clock-frequency = <9600000>;
+		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
+		port {
+			csi_cam1: endpoint {
+				remote-endpoint = <&csi_out1>;
+			};
+		};
+	};
+};

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v6] media: et8ek8: add device tree binding documentation
  2016-11-14 18:30     ` [PATCH v6] " Pavel Machek
@ 2016-11-14 18:39       ` Rob Herring
  2016-12-20 13:05       ` Sakari Ailus
  1 sibling, 0 replies; 14+ messages in thread
From: Rob Herring @ 2016-11-14 18:39 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Ivaylo Dimitrov, Sakari Ailus, Sebastian Reichel,
	Pali Rohár, linux-media, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Mauro Carvalho Chehab, devicetree,
	linux-kernel

On Mon, Nov 14, 2016 at 12:30 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Add device tree binding documentation for toshiba et8ek8 sensor.
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v6] media: et8ek8: add device tree binding documentation
  2016-11-14 18:30     ` [PATCH v6] " Pavel Machek
  2016-11-14 18:39       ` Rob Herring
@ 2016-12-20 13:05       ` Sakari Ailus
  2016-12-21 13:20         ` Pavel Machek
  1 sibling, 1 reply; 14+ messages in thread
From: Sakari Ailus @ 2016-12-20 13:05 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Rob Herring, ivo.g.dimitrov.75, sre, pali.rohar, linux-media,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

Hi Pavel,

On Mon, Nov 14, 2016 at 07:30:40PM +0100, Pavel Machek wrote:
> Add device tree binding documentation for toshiba et8ek8 sensor.
> 
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> ---
> 
> v6: added missing article, fixed signal polarity.
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> new file mode 100644
> index 0000000..b03b21d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> @@ -0,0 +1,53 @@
> +Toshiba et8ek8 5MP sensor
> +
> +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
> +
> +More detailed documentation can be found in
> +Documentation/devicetree/bindings/media/video-interfaces.txt .
> +
> +
> +Mandatory properties
> +--------------------
> +
> +- compatible: "toshiba,et8ek8"
> +- reg: I2C address (0x3e, or an alternative address)
> +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
> +- clocks: External clock to the sensor
> +- clock-frequency: Frequency of the external clock to the sensor. Camera
> +  driver will set this frequency on the external clock. The clock frequency is
> +  a pre-determined frequency known to be suitable to the board.
> +- reset-gpios: XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
> +  is in hardware standby mode when the signal is in the low state.
> +
> +
> +Endpoint node mandatory properties
> +----------------------------------
> +
> +- remote-endpoint: A phandle to the bus receiver's endpoint node.
> +
> +Endpoint node optional properties
> +----------------------------------
> +
> +- clock-lanes: <0>
> +- data-lanes: <1..n>

The driver makes no use of them and CCP2 only supports a single lane. I'll
just remove these and apply it to my tree. Let's continue discussing the
driver patch in the other thread.

> +
> +Example
> +-------
> +
> +&i2c3 {
> +	clock-frequency = <400000>;
> +
> +	cam1: camera@3e {
> +		compatible = "toshiba,et8ek8";
> +		reg = <0x3e>;
> +		vana-supply = <&vaux4>;
> +		clocks = <&isp 0>;
> +		clock-frequency = <9600000>;
> +		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
> +		port {
> +			csi_cam1: endpoint {
> +				remote-endpoint = <&csi_out1>;
> +			};
> +		};
> +	};
> +};
> 

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v6] media: et8ek8: add device tree binding documentation
  2016-12-20 13:05       ` Sakari Ailus
@ 2016-12-21 13:20         ` Pavel Machek
  0 siblings, 0 replies; 14+ messages in thread
From: Pavel Machek @ 2016-12-21 13:20 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: Rob Herring, ivo.g.dimitrov.75, sre, pali.rohar, linux-media,
	pawel.moll, mark.rutland, ijc+devicetree, galak, mchehab,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

On Tue 2016-12-20 15:05:39, Sakari Ailus wrote:
> Hi Pavel,
> 
> > +Endpoint node mandatory properties
> > +----------------------------------
> > +
> > +- remote-endpoint: A phandle to the bus receiver's endpoint node.
> > +
> > +Endpoint node optional properties
> > +----------------------------------
> > +
> > +- clock-lanes: <0>
> > +- data-lanes: <1..n>
> 
> The driver makes no use of them and CCP2 only supports a single lane. I'll
> just remove these and apply it to my tree. Let's continue discussing the
> driver patch in the other thread.

Ok, thanks!

								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2016-12-21 13:20 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-23 19:17 [PATCH v4] media: et8ek8: add device tree binding documentation Pavel Machek
2016-10-23 20:06 ` Sakari Ailus
2016-10-30 20:41 ` Rob Herring
2016-10-31 22:47   ` Sakari Ailus
2016-11-03 12:47   ` Pavel Machek
2016-11-03 22:20     ` Sakari Ailus
2016-11-07 10:36       ` Pavel Machek
2016-11-07 10:46   ` [PATCH v5] " Pavel Machek
2016-11-11 12:17     ` Pavel Machek
2016-11-14 16:20     ` Rob Herring
2016-11-14 18:30     ` [PATCH v6] " Pavel Machek
2016-11-14 18:39       ` Rob Herring
2016-12-20 13:05       ` Sakari Ailus
2016-12-21 13:20         ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).