From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753620AbcKGNZN (ORCPT ); Mon, 7 Nov 2016 08:25:13 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:51763 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbcKGNZK (ORCPT ); Mon, 7 Nov 2016 08:25:10 -0500 Date: Mon, 7 Nov 2016 14:25:01 +0100 From: Sebastian Andrzej Siewior To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, rt@linutronix.de, Tony Luck , linux-edac@vger.kernel.org, x86@kernel.org, Thomas Gleixner Subject: Re: [PATCH 21/25] x86/mcheck: Split threshold_cpu_callback into two callbacks Message-ID: <20161107132500.ptxf6b4ql56pketo@linutronix.de> References: <20161103145021.28528-1-bigeasy@linutronix.de> <20161103145021.28528-22-bigeasy@linutronix.de> <20161107132040.w6oaoe2hu6hpdvy4@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161107132040.w6oaoe2hu6hpdvy4@pd.tnic> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-11-07 14:20:40 [+0100], Borislav Petkov wrote: > Let's get rid of those pointers and pointer testing and export the > create/remove functions directly. This moves it 1:1 (well, more or less). Wouldn't you prefer doing it as separate patch/change? > How's that? It builds here. CONFIG_X86_MCE_AMD is where the callback is implemented. Wouldn't that be broken now? Sebastian