From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481AbcKGP0Z (ORCPT ); Mon, 7 Nov 2016 10:26:25 -0500 Received: from muru.com ([72.249.23.125]:57434 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752646AbcKGP0Y (ORCPT ); Mon, 7 Nov 2016 10:26:24 -0500 Date: Mon, 7 Nov 2016 08:26:13 -0700 From: Tony Lindgren To: Linus Walleij Cc: Jon Hunter , Mark Rutland , Rob Herring , Grygorii Strashko , Nishanth Menon , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux-OMAP Subject: Re: [PATCH 1/4] pinctrl: Introduce generic #pinctrl-cells and pinctrl_parse_index_with_args Message-ID: <20161107152613.GA2428@atomide.com> References: <20161103163550.27330-1-tony@atomide.com> <20161103163550.27330-2-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Linus Walleij [161104 14:50]: > On Thu, Nov 3, 2016 at 5:35 PM, Tony Lindgren wrote: > > > Introduce #pinctrl-cells helper binding and generic helper functions > > pinctrl_count_index_with_args() and pinctrl_parse_index_with_args(). > > > > Acked-by: Rob Herring > > Signed-off-by: Tony Lindgren > > Ooops applied this v2 version instead of the v1. No problem, only the pinctrl-single patches needed reposting. > * kbuild test robot [161103 13:29]: > > In file included from drivers/pinctrl/core.c:36:0: > > >> drivers/pinctrl/devicetree.h:29:14: warning: 'struct of_phandle_args' declared inside parameter list will not be visible outside of this > definition or declaratio > > > Hmm maybe we should just include of.h in core.c? > > Nah. I just did this: > > diff --git a/drivers/pinctrl/devicetree.h b/drivers/pinctrl/devicetree.h > index 7f0a5c4e15ad..c2d1a5505850 100644 > --- a/drivers/pinctrl/devicetree.h > +++ b/drivers/pinctrl/devicetree.h > @@ -16,6 +16,8 @@ > * along with this program. If not, see . > */ > > +struct of_phandle_args; > + > #ifdef CONFIG_OF > > Let's see if it works! OK so do we know now? It seems there was one more email about it but it may have been without it. Thanks, Tony