From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752496AbcKGUuv (ORCPT ); Mon, 7 Nov 2016 15:50:51 -0500 Received: from smtprelay0058.hostedemail.com ([216.40.44.58]:38877 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752104AbcKGUuu (ORCPT ); Mon, 7 Nov 2016 15:50:50 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1538:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3622:3865:3867:3872:5007:6261:7514:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12438:12740:12760:13069:13311:13357:13439:13618:14181:14659:14721:21080:30054:30064:30070:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:26,LUA_SUMMARY:none X-HE-Tag: cap59_7b6ca76ba9a29 X-Filterd-Recvd-Size: 1341 Date: Mon, 7 Nov 2016 15:50:46 -0500 From: Steven Rostedt To: Alexei Starovoitov Cc: Martin KaFai Lau , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: ftrace module init race/bug Message-ID: <20161107155046.59df2467@gandalf.local.home> In-Reply-To: <20161107203540.GA29563@ast-mbp.thefacebook.com> References: <20161107194621.GA28484@ast-mbp.thefacebook.com> <20161107150841.04577223@gandalf.local.home> <20161107203540.GA29563@ast-mbp.thefacebook.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Nov 2016 12:35:42 -0800 Alexei Starovoitov wrote: > > Actually, this may be correct. I need to audit the other > > do_for_each_ftrace_rec() loops. > > yep, the __ftrace_hash_rec_update() has !FTRACE_FL_DISABLED check, > so I thought ftrace_shutdown() may need it too. > Should I send the above patch with proper sob? Yeah, go ahead. -- Steve