linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk
@ 2016-11-01  1:56 Marcos Paulo de Souza
  2016-11-05 18:24 ` Darren Hart
  0 siblings, 1 reply; 6+ messages in thread
From: Marcos Paulo de Souza @ 2016-11-01  1:56 UTC (permalink / raw)
  To: corentin.chary, dvhart, acpi4asus-user, platform-driver-x86,
	linux-kernel
  Cc: Marcos Paulo de Souza, stable

Without this patch, the Asus X45U wireless card can't be turned
on (hard-blocked), but after a suspend/resume it just starts working.

Following this bug report[1], there are other cases like this one, but
this Asus is the only model that I can test.

[1] https://ubuntuforums.org/showthread.php?t=2181558

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: <stable@vger.kernel.org>

---
This patch applies smoothly in 4.8.6 and 4.4.29. I hope now I followed
the instructions correctly.

v1 -> v2:
 Add stable copy and specify the stable version to apply this patch

 drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 26e4cbc..6032b70 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -175,6 +175,15 @@ static const struct dmi_system_id asus_quirks[] = {
 	},
 	{
 		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X45U",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X45U"),
+		},
+		.driver_data = &quirk_asus_wapf4,
+	},
+	{
+		.callback = dmi_matched,
 		.ident = "ASUSTeK COMPUTER INC. X456UA",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-- 
2.7.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk
  2016-11-01  1:56 [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza
@ 2016-11-05 18:24 ` Darren Hart
  2016-11-06  2:05   ` Marcos Paulo de Souza
  0 siblings, 1 reply; 6+ messages in thread
From: Darren Hart @ 2016-11-05 18:24 UTC (permalink / raw)
  To: Marcos Paulo de Souza
  Cc: corentin.chary, acpi4asus-user, platform-driver-x86,
	linux-kernel, stable

On Mon, Oct 31, 2016 at 11:56:10PM -0200, Marcos Paulo de Souza wrote:
> Without this patch, the Asus X45U wireless card can't be turned
> on (hard-blocked), but after a suspend/resume it just starts working.
> 
> Following this bug report[1], there are other cases like this one, but
> this Asus is the only model that I can test.
> 
> [1] https://ubuntuforums.org/showthread.php?t=2181558
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> Cc: <stable@vger.kernel.org>
> 
> ---
> This patch applies smoothly in 4.8.6 and 4.4.29. I hope now I followed
> the instructions correctly.

Hi Marcos,

You'll find exact steps in the stable_kernel_rules.txt document regarding how to
annotate the commit message with Cc lines indicating to which versions this
patch should be applied.

If, for example, you have verified that this patch is relevant only to 4.4 and
forward, you would include:

Cc: <stable@vger.kernel.org> # 4.4.x-

But this should mean that the patch is explicitly broken or otherwise
inappropriate for 4.3 and earlier.

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk
  2016-11-05 18:24 ` Darren Hart
@ 2016-11-06  2:05   ` Marcos Paulo de Souza
  2016-11-07 18:35     ` Darren Hart
  0 siblings, 1 reply; 6+ messages in thread
From: Marcos Paulo de Souza @ 2016-11-06  2:05 UTC (permalink / raw)
  To: Darren Hart
  Cc: corentin.chary, acpi4asus-user, platform-driver-x86,
	linux-kernel, stable

Hi Darren,

On Sat, Nov 05, 2016 at 11:24:04AM -0700, Darren Hart wrote:
> On Mon, Oct 31, 2016 at 11:56:10PM -0200, Marcos Paulo de Souza wrote:
> > Without this patch, the Asus X45U wireless card can't be turned
> > on (hard-blocked), but after a suspend/resume it just starts working.
> > 
> > Following this bug report[1], there are other cases like this one, but
> > this Asus is the only model that I can test.
> > 
> > [1] https://ubuntuforums.org/showthread.php?t=2181558
> > 
> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> > Cc: <stable@vger.kernel.org>
> > 
> > ---
> > This patch applies smoothly in 4.8.6 and 4.4.29. I hope now I followed
> > the instructions correctly.
> 
> Hi Marcos,
> 
> You'll find exact steps in the stable_kernel_rules.txt document regarding how to
> annotate the commit message with Cc lines indicating to which versions this
> patch should be applied.
> 
> If, for example, you have verified that this patch is relevant only to 4.4 and
> forward, you would include:
> 
> Cc: <stable@vger.kernel.org> # 4.4.x-
> 
> But this should mean that the patch is explicitly broken or otherwise
> inappropriate for 4.3 and earlier.

Yes, I have misread the documentation. I could apply the patch as is just in
the versions 4.8.6 and 4.4.29, but maybe I could rework te patch earlier versions.

But, aside from stable tree, do you agree with this change, since it fixes the
wireless problem in this laptop?

Thanks,

> 
> Thanks,
> 
> -- 
> Darren Hart
> Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk
  2016-11-06  2:05   ` Marcos Paulo de Souza
@ 2016-11-07 18:35     ` Darren Hart
  2016-11-07 20:13       ` Marcos Paulo de Souza
  2016-11-08  0:10       ` Marcos Paulo de Souza
  0 siblings, 2 replies; 6+ messages in thread
From: Darren Hart @ 2016-11-07 18:35 UTC (permalink / raw)
  To: Marcos Paulo de Souza
  Cc: corentin.chary, acpi4asus-user, platform-driver-x86,
	linux-kernel, stable

On Sun, Nov 06, 2016 at 12:05:12AM -0200, Marcos Paulo de Souza wrote:
> Hi Darren,
> 
> On Sat, Nov 05, 2016 at 11:24:04AM -0700, Darren Hart wrote:
> > On Mon, Oct 31, 2016 at 11:56:10PM -0200, Marcos Paulo de Souza wrote:
> > > Without this patch, the Asus X45U wireless card can't be turned
> > > on (hard-blocked), but after a suspend/resume it just starts working.
> > > 
> > > Following this bug report[1], there are other cases like this one, but
> > > this Asus is the only model that I can test.
> > > 
> > > [1] https://ubuntuforums.org/showthread.php?t=2181558
> > > 
> > > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> > > Cc: <stable@vger.kernel.org>
> > > 
> > > ---
> > > This patch applies smoothly in 4.8.6 and 4.4.29. I hope now I followed
> > > the instructions correctly.
> > 
> > Hi Marcos,
> > 
> > You'll find exact steps in the stable_kernel_rules.txt document regarding how to
> > annotate the commit message with Cc lines indicating to which versions this
> > patch should be applied.
> > 
> > If, for example, you have verified that this patch is relevant only to 4.4 and
> > forward, you would include:
> > 
> > Cc: <stable@vger.kernel.org> # 4.4.x-
> > 
> > But this should mean that the patch is explicitly broken or otherwise
> > inappropriate for 4.3 and earlier.
> 
> Yes, I have misread the documentation. I could apply the patch as is just in
> the versions 4.8.6 and 4.4.29, but maybe I could rework te patch earlier versions.
> 
> But, aside from stable tree, do you agree with this change, since it fixes the
> wireless problem in this laptop?

Yes, no objection to the patch. It happened to land right about the time we were
having the "be better about how you manage your stable commits" discussion at
kernel summit, so it got some extra focus :-)

Care to resend with the Cc stable tag corrected?

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk
  2016-11-07 18:35     ` Darren Hart
@ 2016-11-07 20:13       ` Marcos Paulo de Souza
  2016-11-08  0:10       ` Marcos Paulo de Souza
  1 sibling, 0 replies; 6+ messages in thread
From: Marcos Paulo de Souza @ 2016-11-07 20:13 UTC (permalink / raw)
  To: Darren Hart
  Cc: corentin.chary, acpi4asus-user, platform-driver-x86,
	linux-kernel, stable

Hi Darren,

On Mon, Nov 07, 2016 at 10:35:05AM -0800, Darren Hart wrote:
> On Sun, Nov 06, 2016 at 12:05:12AM -0200, Marcos Paulo de Souza wrote:
> > Hi Darren,
> > 
> > On Sat, Nov 05, 2016 at 11:24:04AM -0700, Darren Hart wrote:
> > > On Mon, Oct 31, 2016 at 11:56:10PM -0200, Marcos Paulo de Souza wrote:
> > > > Without this patch, the Asus X45U wireless card can't be turned
> > > > on (hard-blocked), but after a suspend/resume it just starts working.
> > > > 
> > > > Following this bug report[1], there are other cases like this one, but
> > > > this Asus is the only model that I can test.
> > > > 
> > > > [1] https://ubuntuforums.org/showthread.php?t=2181558
> > > > 
> > > > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> > > > Cc: <stable@vger.kernel.org>
> > > > 
> > > > ---
> > > > This patch applies smoothly in 4.8.6 and 4.4.29. I hope now I followed
> > > > the instructions correctly.
> > > 
> > > Hi Marcos,
> > > 
> > > You'll find exact steps in the stable_kernel_rules.txt document regarding how to
> > > annotate the commit message with Cc lines indicating to which versions this
> > > patch should be applied.
> > > 
> > > If, for example, you have verified that this patch is relevant only to 4.4 and
> > > forward, you would include:
> > > 
> > > Cc: <stable@vger.kernel.org> # 4.4.x-
> > > 
> > > But this should mean that the patch is explicitly broken or otherwise
> > > inappropriate for 4.3 and earlier.
> > 
> > Yes, I have misread the documentation. I could apply the patch as is just in
> > the versions 4.8.6 and 4.4.29, but maybe I could rework te patch earlier versions.
> > 
> > But, aside from stable tree, do you agree with this change, since it fixes the
> > wireless problem in this laptop?
> 
> Yes, no objection to the patch. It happened to land right about the time we were
> having the "be better about how you manage your stable commits" discussion at
> kernel summit, so it got some extra focus :-)
> 
> Care to resend with the Cc stable tag corrected?

Absolutely not. I just sent a new version with the version along with
the stable email.

Thanks for your patience in this subject :)

> 
> -- 
> Darren Hart
> Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk
  2016-11-07 18:35     ` Darren Hart
  2016-11-07 20:13       ` Marcos Paulo de Souza
@ 2016-11-08  0:10       ` Marcos Paulo de Souza
  1 sibling, 0 replies; 6+ messages in thread
From: Marcos Paulo de Souza @ 2016-11-08  0:10 UTC (permalink / raw)
  To: Darren Hart
  Cc: corentin.chary, acpi4asus-user, platform-driver-x86,
	linux-kernel, gregkh

Hi Darren,

On Mon, Nov 07, 2016 at 10:35:05AM -0800, Darren Hart wrote:
> On Sun, Nov 06, 2016 at 12:05:12AM -0200, Marcos Paulo de Souza wrote:
> > Hi Darren,
> > 
> > On Sat, Nov 05, 2016 at 11:24:04AM -0700, Darren Hart wrote:
> > > On Mon, Oct 31, 2016 at 11:56:10PM -0200, Marcos Paulo de Souza wrote:
> > > > Without this patch, the Asus X45U wireless card can't be turned
> > > > on (hard-blocked), but after a suspend/resume it just starts working.
> > > > 
> > > > Following this bug report[1], there are other cases like this one, but
> > > > this Asus is the only model that I can test.
> > > > 
> > > > [1] https://ubuntuforums.org/showthread.php?t=2181558
> > > > 
> > > > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> > > > Cc: <stable@vger.kernel.org>
> > > > 
> > > > ---
> > > > This patch applies smoothly in 4.8.6 and 4.4.29. I hope now I followed
> > > > the instructions correctly.
> > > 
> > > Hi Marcos,
> > > 
> > > You'll find exact steps in the stable_kernel_rules.txt document regarding how to
> > > annotate the commit message with Cc lines indicating to which versions this
> > > patch should be applied.
> > > 
> > > If, for example, you have verified that this patch is relevant only to 4.4 and
> > > forward, you would include:
> > > 
> > > Cc: <stable@vger.kernel.org> # 4.4.x-
> > > 
> > > But this should mean that the patch is explicitly broken or otherwise
> > > inappropriate for 4.3 and earlier.
> > 
> > Yes, I have misread the documentation. I could apply the patch as is just in
> > the versions 4.8.6 and 4.4.29, but maybe I could rework te patch earlier versions.
> > 
> > But, aside from stable tree, do you agree with this change, since it fixes the
> > wireless problem in this laptop?
> 
> Yes, no objection to the patch. It happened to land right about the time we were
> having the "be better about how you manage your stable commits" discussion at
> kernel summit, so it got some extra focus :-)
> 
> Care to resend with the Cc stable tag corrected?

I had some problem to send the patch through git send-email and mutt,
because the stable address and the version always got merged. So Laura
Abbott helped me with the tip of --suppress-cc=bodycc, and then I added
stable address manually.

Is there a new procedure to send a patch to stable, without being this
tricky? Is there is, I would be happy to send a patch to fix our
documentation, since even people from kernel newbies are suffering by
the same problem[1]

Thanks in advance.

[1]
https://lists.kernelnewbies.org/pipermail/kernelnewbies/2016-April/016194.html

> 
> -- 
> Darren Hart
> Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-11-08  0:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-01  1:56 [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza
2016-11-05 18:24 ` Darren Hart
2016-11-06  2:05   ` Marcos Paulo de Souza
2016-11-07 18:35     ` Darren Hart
2016-11-07 20:13       ` Marcos Paulo de Souza
2016-11-08  0:10       ` Marcos Paulo de Souza

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).