From: Josh Triplett <josh@joshtriplett.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: John Stultz <john.stultz@linaro.org>,
Michal Marek <mmarek@suse.com>,
Richard Cochran <richardcochran@gmail.com>,
Paul Bolle <pebolle@tiscali.nl>,
Thomas Gleixner <tglx@linutronix.de>,
Edward Cree <ecree@solarflare.com>,
netdev@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes
Date: Mon, 7 Nov 2016 15:12:36 -0800 [thread overview]
Message-ID: <20161107231236.c7p7fqefckwxcsvv@jtriplet-mobl2.jf.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1611071733010.14694@knanqh.ubzr>
On Mon, Nov 07, 2016 at 05:41:38PM -0500, Nicolas Pitre wrote:
> On Mon, 7 Nov 2016, Josh Triplett wrote:
>
> > [snipping large patch]
> >
> > One suggestion that might make this patch easier to review: you might
> > consider first regenerating the unchanged parser with Bison 3.0.4, then
> > regenerating it again after the "imply" change. I think that'd
> > eliminate quite a lot of noise in this patch.
>
> I tried that. This made two large patches instead of just one, both
> equally obscure.
>
> So this patch stands on its own, containing changes that are
> mechanically generated and therefore shouldn't require manual review.
Fair enough. I hadn't expected that the changes from "imply" would still
be huge.
next prev parent reply other threads:[~2016-11-07 23:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 22:14 [PATCH v3 0/4] make POSIX timers optional with some Kconfig help Nicolas Pitre
2016-11-07 22:14 ` [PATCH v3 1/4] kconfig: introduce the "imply" keyword Nicolas Pitre
2016-11-07 22:14 ` [PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes Nicolas Pitre
2016-11-07 22:31 ` Josh Triplett
2016-11-07 22:41 ` Nicolas Pitre
2016-11-07 23:12 ` Josh Triplett [this message]
2016-11-07 22:14 ` [PATCH v3 3/4] ptp_clock: allow for it to be optional Nicolas Pitre
2016-11-08 13:10 ` Edward Cree
2016-11-07 22:14 ` [PATCH v3 4/4] posix-timers: make it configurable Nicolas Pitre
2016-11-08 17:42 ` John Stultz
2016-11-08 18:19 ` Nicolas Pitre
2016-11-08 18:48 ` John Stultz
2016-11-07 22:31 ` [PATCH v3 0/4] make POSIX timers optional with some Kconfig help Nicolas Pitre
2016-11-08 16:47 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107231236.c7p7fqefckwxcsvv@jtriplet-mobl2.jf.intel.com \
--to=josh@joshtriplett.org \
--cc=ecree@solarflare.com \
--cc=john.stultz@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=pebolle@tiscali.nl \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).