From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Roth <chris.roth@usask.ca>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Allan Chou <allan@asix.com.tw>,
Artjom Simon <artjom.simon@gmail.com>
Subject: Re: [PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.
Date: Tue, 8 Nov 2016 07:48:42 +0100 [thread overview]
Message-ID: <20161108064842.GB13024@kroah.com> (raw)
In-Reply-To: <CAPZMiRa0kYyPFQ77L5y4NgxxH85iuMAjODV2iCzd-5OjyGfNuw@mail.gmail.com>
On Mon, Nov 07, 2016 at 04:44:20PM -0600, Chris Roth wrote:
> From: Allan Chou <allan@asix.com.tw>
>
> Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet
> Bridge Controller (Vendor=04b4 ProdID=3610).
>
> Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems
> with the Kensington SD4600P USB-C Universal Dock with Power,
> which uses the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge
> Controller.
>
> A similar patch was signed-off and tested-by Allan Chou
> <allan@asix.com.tw> on 2015-12-01.
>
> Allan verified his similar patch on x86 Linux kernel 4.1.6 system
> with Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller.
>
> Tested-by: Allan Chou <allan@asix.com.tw>
> Tested-by: Chris Roth <chris.roth@usask.ca>
> Tested-by: Artjom Simon <artjom.simon@gmail.com>
>
> Signed-off-by: Allan Chou <allan@asix.com.tw>
> Signed-off-by: Chris Roth <chris.roth@usask.ca>
> ---
> drivers/net/usb/ax88179_178a.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
> index e6338c1..8a6675d 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -1656,6 +1656,19 @@ static const struct driver_info ax88178a_info = {
> .tx_fixup = ax88179_tx_fixup,
> };
>
> +static const struct driver_info cypress_GX3_info = {
> + .description = "Cypress GX3 SuperSpeed to Gigabit Ethernet Controller",
> + .bind = ax88179_bind,
> + .unbind = ax88179_unbind,
> + .status = ax88179_status,
> + .link_reset = ax88179_link_reset,
> + .reset = ax88179_reset,
> + .stop = ax88179_stop,
> + .flags = FLAG_ETHER | FLAG_FRAMING_AX,
> + .rx_fixup = ax88179_rx_fixup,
> + .tx_fixup = ax88179_tx_fixup,
> +};
Your tabs got eaten and converted to spaces, making this patch
impossible to apply :(
And you forgot to list what changed from v3, please put that below the
--- line.
thanks,
greg k-h
next prev parent reply other threads:[~2016-11-08 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 22:44 [PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610 Chris Roth
2016-11-08 6:48 ` Greg KH [this message]
2016-11-08 22:08 ` [PATCH v5] " chris.roth
2016-11-10 2:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108064842.GB13024@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=allan@asix.com.tw \
--cc=artjom.simon@gmail.com \
--cc=chris.roth@usask.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).