From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932477AbcKHGuw (ORCPT ); Tue, 8 Nov 2016 01:50:52 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39560 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932188AbcKHGuv (ORCPT ); Tue, 8 Nov 2016 01:50:51 -0500 Date: Tue, 8 Nov 2016 07:50:58 +0100 From: Greg Kroah-Hartman To: Eugene Korenevsky Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Luiz Capitulino , Linus Torvalds , Chase Metzger , Alan Stern , Mathias Nyman , Lu Baolu , Oliver Neukum , Hans Yang Subject: Re: [PATCH v3 1/2] USB hub_probe: rework ugly goto-into-compound-statement Message-ID: <20161108065058.GC13024@kroah.com> References: <20161107185350.GA18986@vnote> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161107185350.GA18986@vnote> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2016 at 09:53:50PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > drivers/usb/core/hub.c | 33 ++++++++++++++++----------------- > 1 file changed, 16 insertions(+), 17 deletions(-) You forgot to list what changed from v2 here :(