From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbcKHHwF (ORCPT ); Tue, 8 Nov 2016 02:52:05 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:40252 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140AbcKHHwE (ORCPT ); Tue, 8 Nov 2016 02:52:04 -0500 X-Greylist: delayed 466 seconds by postgrey-1.27 at vger.kernel.org; Tue, 08 Nov 2016 02:52:03 EST Date: Tue, 8 Nov 2016 08:44:14 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Liam Girdwood , Mark Brown , linux-arm-kernel , linux-kernel , Linux-ALSA Subject: Re: [PATCH 3/3] ARM: gr8: evb: Add i2s codec Message-ID: <20161108074414.vvnjj7aa26sloi2f@lukather> References: <4d99da31af41b26d9109113e19223ee8b88f76ae.1478524066.git-series.maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qxjcnworssfre7k4" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qxjcnworssfre7k4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 07, 2016 at 10:11:45PM +0800, Chen-Yu Tsai wrote: > On Mon, Nov 7, 2016 at 9:08 PM, Maxime Ripard > wrote: > > The GR8-EVB comes with a wm8978 codec connected to the i2s bus. > > > > Add a card in order to have it working > > > > Signed-off-by: Maxime Ripard > > --- > > arch/arm/boot/dts/ntc-gr8-evb.dts | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/boot/dts/ntc-gr8-evb.dts b/arch/arm/boot/dts/ntc-= gr8-evb.dts > > index 12b4317a4383..5291e425caf9 100644 > > --- a/arch/arm/boot/dts/ntc-gr8-evb.dts > > +++ b/arch/arm/boot/dts/ntc-gr8-evb.dts > > @@ -76,6 +76,20 @@ > > default-brightness-level =3D <8>; > > }; > > > > + i2s { >=20 > "sound" might be a better node name? The I2S controllers are also > named "i2s". I know, but we also had the codec and SPDIF on this board, so sound was too generic to be meaningful I guess. I don't really care about the name though, if you have any suggestion... > Otherwise, >=20 > Acked-by: Chen-Yu Tsai Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --qxjcnworssfre7k4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYIYJKAAoJEBx+YmzsjxAgo+cP/jkgGy+35Chjud7fSEEaIU9q Z4LoS7kN6w8T/yE2L7ZMVgLHrCKYPge3B5FYjFjSwHREXD+OUQbh9vgr8YiAx3Mm /lj7xXIX1deUVEAqYQMP+zgtI4Ud4HYbGm9vnORHuA0Df1HnXk7vv/olsD9+84cr Vrj3XoncmQzhyQ/cucgc42tXdbNPLlzQP+phftZD166PaMsXiDGTzZUszBgoJJTR GWNxGaxQAS+UjsawPrApW6TkecdvwHZ05B+s86/0yEzkBExkR8xnN3SAu6gg0Gqn k++5jjX28V4+SLjXUiueqN4jfT3V9Dlc9WSFanExGb93TfQqh1UnpBc6oNI6QRzk 3YW8PLi6WRkrlUvKOVmQaoZDXKJm2JorrF2N9unuLKAei2f8Dp0cOABB9hZc5B1U CSVAQRkMc5pY3EKQhvB/szrlyvvi7HcfeOJEIwKDH3l0npXl9FB41KEU9IRGoLHO WVYusHxAZtcBby1GayPrOtI98ftXr+F4xGjS3CZrAP6g3gQjy8Vzco7dyr1VFPwI wI6gPVJ/EEgE/tcAh+ITGV38ENdFSzpeK8wpvdHZ3zTZ9bs3txagehRWJiASD5Bw WM9Oax7kqdiRayCQB1eMoVqUYa32dFa8wnktX1s6sTkAVmWnd8aEBLKdV8o2QPgY T0PwF6M/71Ysl/NtDo2E =uXVQ -----END PGP SIGNATURE----- --qxjcnworssfre7k4--