Re: [PATCH v2 12/12] mm: memory_hotplug: memory hotremove supports thp migration

From: kbuild test robot <lkp@intel.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: kbuild-all@01.org, linux-mm@kvack.org,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Mel Gorman <mgorman@techsingularity.net>,
	Michal Hocko <mhocko@kernel.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Pavel Emelyanov <xemul@parallels.com>,
	Zi Yan <zi.yan@cs.rutgers.edu>,
	Balbir Singh <bsingharora@gmail.com>,
	linux-kernel@vger.kernel.org,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Naoya Horiguchi <nao.horiguchi@gmail.com>
Subject: Re: [PATCH v2 12/12] mm: memory_hotplug: memory hotremove supports thp migration
Date: Tue, 8 Nov 2016 08:30:10 +0800	[thread overview]
Message-ID: <201611080850.MhSq3cNm%fengguang.wu@intel.com> (raw)
In-Reply-To: <1478561517-4317-13-git-send-email-n-horiguchi@ah.jp.nec.com>

[-- Attachment #1: Type: text/plain, Size: 3756 bytes --]

Hi Naoya,

[auto build test WARNING on mmotm/master]
[also build test WARNING on next-20161028]
[cannot apply to v4.9-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Naoya-Horiguchi/mm-x86-move-_PAGE_SWP_SOFT_DIRTY-from-bit-7-to-bit-6/20161108-080615
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: x86_64-randconfig-x003-201645 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   mm/memory_hotplug.c: In function 'try_offline_node':
   mm/memory_hotplug.c:2131:6: warning: unused variable 'i' [-Wunused-variable]
     int i;
         ^
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from mm/memory_hotplug.c:7:
   mm/memory_hotplug.c: In function 'new_node_page':
   include/linux/compiler.h:518:38: error: call to '__compiletime_assert_1575' declared with attribute error: BUILD_BUG failed
     _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
                                         ^
   include/linux/compiler.h:160:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> mm/memory_hotplug.c:1575:2: note: in expansion of macro 'if'
     if (new_page && order == HPAGE_PMD_ORDER)
     ^~
   include/linux/compiler.h:506:2: note: in expansion of macro '__compiletime_assert'
     __compiletime_assert(condition, msg, prefix, suffix)
     ^~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:518:2: note: in expansion of macro '_compiletime_assert'
     _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/bug.h:54:37: note: in expansion of macro 'compiletime_assert'
    #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                        ^~~~~~~~~~~~~~~~~~
   include/linux/bug.h:88:21: note: in expansion of macro 'BUILD_BUG_ON_MSG'
    #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed")
                        ^~~~~~~~~~~~~~~~
   include/linux/huge_mm.h:181:28: note: in expansion of macro 'BUILD_BUG'
    #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; })
                               ^~~~~~~~~
   include/linux/huge_mm.h:56:26: note: in expansion of macro 'HPAGE_PMD_SHIFT'
    #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT)
                             ^~~~~~~~~~~~~~~
   mm/memory_hotplug.c:1575:27: note: in expansion of macro 'HPAGE_PMD_ORDER'
     if (new_page && order == HPAGE_PMD_ORDER)
                              ^~~~~~~~~~~~~~~

vim +/if +1575 mm/memory_hotplug.c

  1559			gfp_mask |= GFP_TRANSHUGE;
  1560		}
  1561	
  1562		node_clear(nid, nmask);
  1563	
  1564		if (PageHighMem(page)
  1565		    || (zone_idx(page_zone(page)) == ZONE_MOVABLE))
  1566			gfp_mask |= __GFP_HIGHMEM;
  1567	
  1568		if (!nodes_empty(nmask))
  1569			new_page = __alloc_pages_nodemask(gfp_mask, order,
  1570						node_zonelist(nid, gfp_mask), &nmask);
  1571		if (!new_page)
  1572			new_page = __alloc_pages(gfp_mask, order,
  1573						node_zonelist(nid, gfp_mask));
  1574	
> 1575		if (new_page && order == HPAGE_PMD_ORDER)
  1576			prep_transhuge_page(new_page);
  1577	
  1578		return new_page;
  1579	}
  1580	
  1581	#define NR_OFFLINE_AT_ONCE_PAGES	(256)
  1582	static int
  1583	do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28889 bytes --]