From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752634AbcKHNoh (ORCPT ); Tue, 8 Nov 2016 08:44:37 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:56733 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752585AbcKHNof (ORCPT ); Tue, 8 Nov 2016 08:44:35 -0500 From: Arnd Bergmann To: Thomas Gleixner Cc: Arnd Bergmann , Fenghua Yu , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] x86/intel_rdt: fix rdt_mount error handling Date: Tue, 8 Nov 2016 14:42:03 +0100 Message-Id: <20161108134233.1803001-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:cJWhx0CfUIU2+bn/9+sybMAzP78Ko930f8oilR3vC2kbT/Ic91f h70vK+UIKBpcMDUqdEL11S7rXzsrnvOa/JlYULjZIjxHL85sfJLWOnYJYtARUfuBDBgNw/H CESIk7Shb4jfSdQadKFnTFYNmpBp++wdMEDhYy9v069MGm/BW8KVB88zo55ZI4ktJvyofXb hiUh/rgFTWgvyFB2ZQytQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:WcrinpfRq1E=:dPBnS9HpOek5Nnv9dAJszs mfbD8IaHOq0dXbaLTl1D4035lHVZvbDdtBVVVdYRXrY2winSWwHcr4ERs85AazHCf+2frOtZm PccLmZvTjU91tg8QFqJB03GHEXNh1yNo7UKAb3jO7snMPBXonRWwiD+UH1ziatF/bCkiW72xG lFDpy7bucXoTTKmmbdL6qmwVS9YmgXrXKJUCzFRVzqXFzgd1Rx6U07uejQZfjXZF1XvTc8EZE TaK2a9E9Wv9ohxbszgq89zdnNweEUKhxGZcc0CdrF0ja9rV2uIGGf0gEg4ko2bp56LbD+FhdK 0ASd6BESdddDY3Hzmlr3PUi0OtRrOYyClcB7cayiFo8hPhJsme3r6A3642XiA2YEBoP+fNiWI R7OZCfYHPlsKDvqnlAu0E71HavPTqFORHo2cnIaWj4Dk/mezlaKK8rlumI/wOayPD450mKg4S 9qS+OW3tTMDrJyGXfqzJFQztndk+Lk0W1SW768Lwu0h6HXHwDoLxGvMkkgHrPeQIfkJGLoHnY BN1Hmnv6hgJU9H78wbscJR56yvhNNxXgNcj65OddqdfFBoEXhQTWLFVHzikvNSrAJRP0oC5b1 GbpqC6ZG1igsu8DCuW5Bc2KgZWVQy5WMLdIhpPgUZRjMufjC5nlzP+dNKDvYZtl5tOGeLTVxL FohyDTWywzY5NZGZM1AJLbX5Pw9wCGa0z+0tq1RbPPx0VKG+YwybFxhJFYIZA67uJ8UzAXbF5 pcxEoV2zLmRq/a2H Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly introduced rdt_mount function returns an unintialized pointer if rdtgroup_create_info_dir() fails: arch/x86/kernel/cpu/intel_rdt_rdtgroup.c: In function ‘rdt_mount’: arch/x86/kernel/cpu/intel_rdt_rdtgroup.c:710:9: error: ‘dentry’ may be used uninitialized in this function [-Werror=maybe-uninitialized] Clearly the intention was to propagate the error code here as we do in the other failure cases. Fixes: 5ff193fbde20 ("x86/intel_rdt: Add basic resctrl filesystem support") Signed-off-by: Arnd Bergmann --- arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c index a90ad22b9823..e66c7a58505e 100644 --- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c +++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c @@ -691,8 +691,10 @@ static struct dentry *rdt_mount(struct file_system_type *fs_type, closid_init(); ret = rdtgroup_create_info_dir(rdtgroup_default.kn); - if (ret) + if (ret) { + dentry = ERR_PTR(ret); goto out_cdp; + } dentry = kernfs_mount(fs_type, flags, rdt_root, RDTGROUP_SUPER_MAGIC, NULL); -- 2.9.0