From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Vince Weaver <vince@deater.net>,
Robert Richter <rric@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Andi Kleen <andi@firstfloor.org>,
kan.liang@intel.com
Subject: Re: [PATCH] perf/x86: Fix overlap counter scheduling bug
Date: Tue, 8 Nov 2016 07:09:49 -0800 [thread overview]
Message-ID: <20161108150949.GM26852@two.firstfloor.org> (raw)
In-Reply-To: <20161108122039.GP3142@twins.programming.kicks-ass.net>
Adding Kan who actually maintains the uncore drivers these days.
> Which is two distinct groups, only one of which has overlap. And the one
> with overlap only has 2 overlapping masks, giving a max reties of 1.
Looks reasonable to limit the mask.
Are we sure this problem isn't in the other 0xc masks too ?
-Andi
>
>
> diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
> index 272427700d48..71bc348736bd 100644
> --- a/arch/x86/events/intel/uncore_snbep.c
> +++ b/arch/x86/events/intel/uncore_snbep.c
> @@ -669,7 +669,7 @@ static struct event_constraint snbep_uncore_cbox_constraints[] = {
> UNCORE_EVENT_CONSTRAINT(0x1c, 0xc),
> UNCORE_EVENT_CONSTRAINT(0x1d, 0xc),
> UNCORE_EVENT_CONSTRAINT(0x1e, 0xc),
> - EVENT_CONSTRAINT_OVERLAP(0x1f, 0xe, 0xff),
> + UNCORE_EVENT_CONSTRAINT(0x1f, 0xc); /* should be 0x0e but that gives scheduling pain */
> UNCORE_EVENT_CONSTRAINT(0x21, 0x3),
> UNCORE_EVENT_CONSTRAINT(0x23, 0x3),
> UNCORE_EVENT_CONSTRAINT(0x31, 0x3),
>
next prev parent reply other threads:[~2016-11-08 15:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 15:44 [PATCH] perf/x86: Fix overlap counter scheduling bug Jiri Olsa
2016-11-08 12:20 ` Peter Zijlstra
2016-11-08 13:14 ` Jiri Olsa
2016-11-08 15:09 ` Andi Kleen [this message]
2016-11-08 16:22 ` Liang, Kan
2016-11-08 16:57 ` Peter Zijlstra
2016-11-08 17:25 ` Liang, Kan
2016-11-08 18:27 ` Peter Zijlstra
2016-11-09 14:25 ` Robert Richter
2016-11-09 15:51 ` Peter Zijlstra
2016-11-10 8:00 ` Ingo Molnar
2016-11-10 16:41 ` Peter Zijlstra
2016-12-14 15:59 ` Jiri Olsa
2016-12-22 16:50 ` [tip:perf/urgent] " tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108150949.GM26852@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rric@kernel.org \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).