From: Daniel Vetter <daniel@ffwll.ch>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: DRI devel <dri-devel@lists.freedesktop.org>,
Mali DP Maintainers <malidp@foss.arm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: mali-dp: Add support for setting plane's rotation property from userspace.
Date: Tue, 8 Nov 2016 17:16:41 +0100 [thread overview]
Message-ID: <20161108161641.haxmqzwkktw3wrfx@phenom.ffwll.local> (raw)
In-Reply-To: <20161108134325.1466-1-Liviu.Dudau@arm.com>
On Tue, Nov 08, 2016 at 01:43:25PM +0000, Liviu Dudau wrote:
> In order to support DRM_IOCTL_MODE_OBJ_SETPROPERTY for the rotation property
> we need to have a ->set_property hook defined for the planes. Set the
> plane's ->set_property hook to drm_atomic_helper_plane_set_property()
>
> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> ---
> drivers/gpu/drm/arm/malidp_planes.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index bb1c528..8eef9a8 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -89,6 +89,7 @@ void malidp_destroy_plane_state(struct drm_plane *plane,
> static const struct drm_plane_funcs malidp_de_plane_funcs = {
> .update_plane = drm_atomic_helper_update_plane,
> .disable_plane = drm_atomic_helper_disable_plane,
> + .set_property = drm_atomic_helper_plane_set_property,
We discussed this a bit, I think it'd be nice to simply make this the
default for all atomic drivers (and demote all the set_prop helpers from
exported helpers to internal static functions). But can be done as a
cleanup later on, ack for this patch meanwhile.
-Daniel
> .destroy = malidp_de_plane_destroy,
> .reset = drm_atomic_helper_plane_reset,
> .atomic_duplicate_state = malidp_duplicate_plane_state,
> --
> 2.10.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2016-11-08 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 13:43 [PATCH] drm: mali-dp: Add support for setting plane's rotation property from userspace Liviu Dudau
2016-11-08 16:16 ` Daniel Vetter [this message]
2016-11-08 16:44 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108161641.haxmqzwkktw3wrfx@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Liviu.Dudau@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malidp@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).