From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: "Benjamin Larsson" <benjamin@southpole.se>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Jörg Otte" <jrg.otte@gmail.com>,
"Patrick Boettcher" <patrick.boettcher@posteo.de>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference
Date: Wed, 9 Nov 2016 18:25:23 -0200 [thread overview]
Message-ID: <20161109182523.43af40bb@vento.lan> (raw)
In-Reply-To: <fac91957-30b0-b16f-a6f3-5bdfd0a65481@gmail.com>
Em Wed, 9 Nov 2016 19:57:58 +0000
Malcolm Priestley <tvboxspy@gmail.com> escreveu:
> > Yeah, I avoided serializing the logic that detects if the firmware is
> > loaded, but forgot that the power control had the same issue. The
> > newer dvb usb drivers use the dvb-usb-v2, so I didn't touch this
> > code for a while.
>
> I think the problem is that the usb buffer has been put in struct
> cinergyt2_state private area which has not been initialized for initial
> usb probing.
>
> That was one of the main reasons for porting drivers to dvb-usb-v2.
True, but converting to dvb-usb-v2, is more complex. In particular,
dib0700 and dib3000 drivers rely on some things that may not be ported
to dvb-usb-v2.
So, I don't think we should do such change during the -rc cycle.
Also, such change requires testing. So, one with those hardware should
help with it, or the developer willing to do the conversion would
need to get those old hardware in hands.
Thanks,
Mauro
next prev parent reply other threads:[~2016-11-09 20:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 15:40 [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference Jörg Otte
2016-11-08 18:42 ` Linus Torvalds
2016-11-08 20:22 ` Mauro Carvalho Chehab
2016-11-08 21:15 ` Benjamin Larsson
2016-11-08 21:38 ` Mauro Carvalho Chehab
2016-11-09 19:57 ` Malcolm Priestley
2016-11-09 20:25 ` Mauro Carvalho Chehab [this message]
2016-11-09 11:09 ` Jörg Otte
2016-11-09 19:07 ` Linus Torvalds
2016-11-09 20:21 ` Mauro Carvalho Chehab
2016-11-10 8:40 ` Mauro Carvalho Chehab
2016-11-10 11:15 ` Jörg Otte
2016-11-11 13:55 ` Mauro Carvalho Chehab
2016-11-11 16:43 ` Jörg Otte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109182523.43af40bb@vento.lan \
--to=mchehab@s-opensource.com \
--cc=benjamin@southpole.se \
--cc=jrg.otte@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=patrick.boettcher@posteo.de \
--cc=torvalds@linux-foundation.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).