From: Stephen Boyd <sboyd@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Michael Turquette <mturquette@baylibre.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return
Date: Wed, 9 Nov 2016 12:04:44 -0800 [thread overview]
Message-ID: <20161109200444.GR16026@codeaurora.org> (raw)
In-Reply-To: <20161108144950.3472058-2-arnd@arndb.de>
On 11/08, Arnd Bergmann wrote:
> The new pxa2xx_determine_rate() function seems lacking in a few
> regards:
>
> - For an exact match or no match at all, the rate is uninitialized
> as reported by gcc -Wmaybe-unintialized:
> drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_determine_rate':
> drivers/clk/pxa/clk-pxa.c:243:5: error: 'rate' may be used uninitialized in this function
>
> - If we get a non-exact match, the req->rate output is never set
> to the actual rate but remains at the requested rate.
>
> - We should not attempt to print a rate if none could be found
>
> This rewrites the logic accordingly.
>
> Fixes: 9fe694295098 ("clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-09 20:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 14:49 [PATCH 1/2] clk: pxa mark dummy helper as 'inline' Arnd Bergmann
2016-11-08 14:49 ` [PATCH 2/2] clk: pxa: fix pxa2xx_determine_rate return Arnd Bergmann
2016-11-08 18:01 ` Robert Jarzmik
2016-11-08 22:22 ` Arnd Bergmann
2016-11-09 7:31 ` Robert Jarzmik
2016-11-09 20:04 ` Stephen Boyd [this message]
2016-11-08 17:50 ` [PATCH 1/2] clk: pxa mark dummy helper as 'inline' Robert Jarzmik
2016-11-08 22:42 ` Stephen Boyd
2016-11-08 22:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109200444.GR16026@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).