From: David Miller <davem@davemloft.net>
To: rafalo@cadence.com
Cc: nicolas.ferre@atmel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5]] cadence: Add LSO support.
Date: Thu, 10 Nov 2016 12:01:23 -0500 (EST) [thread overview]
Message-ID: <20161110.120123.1915127624714352140.davem@davemloft.net> (raw)
In-Reply-To: <1478698862-12924-1-git-send-email-rafalo@cadence.com>
From: Rafal Ozieblo <rafalo@cadence.com>
Date: Wed, 9 Nov 2016 13:41:02 +0000
First, please remove the spurious closing bracket in your Subject line
in future submittions.
> + if (is_udp) /* is_udp is only set when (is_lso) is checked */
> + /* zero UDP checksum, not calculated by h/w for UFO */
> + udp_hdr(skb)->check = 0;
This is really not ok.
If UFO is in use it should not silently disable UDP checksums.
If you cannot support UFO with proper checksumming, then you cannot
enable support for that feature.
next prev parent reply other threads:[~2016-11-10 17:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 13:18 [PATCH] LSO feature added to Cadence GEM driver Rafal Ozieblo
2016-10-24 15:40 ` Eric Dumazet
2016-10-25 12:05 ` [PATCH v2] " Rafal Ozieblo
2016-10-28 17:49 ` David Miller
2016-11-04 11:40 ` [PATCH net-next v3] cadence: Add LSO support Rafal Ozieblo
2016-11-08 1:38 ` David Miller
2016-11-08 13:41 ` [PATCH net-next v4] " Rafal Ozieblo
2016-11-08 19:09 ` Florian Fainelli
2016-11-09 13:41 ` [PATCH net-next v5]] " Rafal Ozieblo
2016-11-10 17:01 ` David Miller [this message]
2016-11-16 10:02 ` [PATCH net-next v6] " Rafal Ozieblo
2016-11-16 22:56 ` David Miller
2016-11-14 9:32 [PATCH net-next v5] " Rafal Ozieblo
2016-11-14 14:35 ` Eric Dumazet
2016-11-14 17:30 ` David Miller
2016-11-15 7:07 ` Rafal Ozieblo
2016-11-15 13:11 ` Eric Dumazet
2016-11-15 14:20 ` Rafal Ozieblo
2016-11-15 15:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110.120123.1915127624714352140.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=rafalo@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).