From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932584AbcKJLdr (ORCPT ); Thu, 10 Nov 2016 06:33:47 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39124 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932351AbcKJLdp (ORCPT ); Thu, 10 Nov 2016 06:33:45 -0500 Date: Thu, 10 Nov 2016 08:26:43 +0100 From: Greg KH To: Sergio Paracuellos Cc: Joe Perches , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/11] staging: wlan-ng: fix line style issue in macro WLAN_GET_FC_FSTYPE Message-ID: <20161110072643.GD31032@kroah.com> References: <1478541328-2214-1-git-send-email-sergio.paracuellos@gmail.com> <1478541328-2214-2-git-send-email-sergio.paracuellos@gmail.com> <1478545060.22008.5.camel@perches.com> <58216428.3040409@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58216428.3040409@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, Nov 08, 2016 at 06:35:36AM +0100, Sergio Paracuellos wrote: > Thanks for pointing that Joe. There other files and macros where > GENMASK stuff could be applied in wlan-ng driver. Maybe it should be better > to apply this patch as it is now and send another patch later which changes > all of them. What do you think? Yes, that would be fine. thanks, greg k-h