From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965047AbcKJTVw (ORCPT ); Thu, 10 Nov 2016 14:21:52 -0500 Received: from mail-by2nam01on0047.outbound.protection.outlook.com ([104.47.34.47]:42880 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932259AbcKJTVu (ORCPT ); Thu, 10 Nov 2016 14:21:50 -0500 X-Greylist: delayed 3553 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Nov 2016 14:21:50 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yazen.Ghannam@amd.com; Date: Thu, 10 Nov 2016 12:50:04 -0500 From: Yazen Ghannam To: , , , , CC: Subject: Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct Message-ID: <20161110175004.lji5k53ccli7gjig@yaz-fedora.dyhomenet> References: <20161103125556.15482-2-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161104 (1.7.1) X-Originating-IP: [73.35.89.163] X-ClientProxiedBy: CY1PR03CA0035.namprd03.prod.outlook.com (10.174.128.45) To CY4PR12MB1382.namprd12.prod.outlook.com (10.168.169.15) X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1382;2:xai+lBigti7zPtbin/OMPx5ut4H1M9f4SW9X8LoLc2L7UMrgdbzRCBTZ8qNIR+HjaNoTYdo8hG95ZmJovwGH7FHYXbfX+mx60BcGw2p4NTxMBZQG14bVD2AZ2xo1zX16nErzkZ8SxS9KFa6XGxh7+HR7OkffhyExYaokvynLabE=;3:NHjj7af9BOhdQ2qgeRjzl6/BWhDpjTTnQg463GFiXewoZy3F7nvt00LPiVdMVEHalG+Lhep8SPVo1z2iC7IDJVU7mgGga425WEbviFdm/1XUc8Vc5tWhMEWgRKwrPjd9+lZd7TRzto7hqlQX6Tu/6fQFhPnRBNFmRzfA+7ETA8s= X-MS-Office365-Filtering-Correlation-Id: 06649ec0-c7d0-4686-592a-08d4099203fe X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR12MB1382; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1382;25:SksKY/XCfna3bVAt+K2VKOBvCkc1cx94ENRsqTAPVRtEm13yLJ3DCpspjAaB1VN2Iu7uSvlkJEEeRTbdXWRjTrag3JDZlKZuBD7E3ifAoZHq2IVWXzyR4WBFFCbLPwQlsOb0Mt2kFp9TEfET9lS319RSxjfnq9IXUNUXZkJKYmI7ojKUkFer2zMhG/R0Scwtu6fhI0grLrLIoQ7XsnzCvcBFMH6hg+Q27qy9PeswnANUf8SWANGHGxuO0W4GzKXSMmYPnYRi4vB7Ha7LCEf6j+fT/LuRKNAs/XMD7x13Z78xbbPVu9O2b6cpgfAm5Cr7MrBHgpt5y00bfg2e7rSoz4lmV2xEuoAKa1ltbv9VOAiMYm9ANls12zT3FXruLk1sFG1/u7ihyNnl7BNWKe2L02YA1LDm6zk05DIjVSEUvr9bvUMp02Uy1J++ThX8c8N5uHf4Qf1qT2MYapN+EjQdxEWC/FAh1m4+6lc2iTLrImjU1n0cQd6UuEwTHiIUpbymEV8dZq44k5w6OKWfv0HgUFmiJZO+KL5bDE5XlrZgR9J/sJxDRdbqfePU9Z/hR1+odmUlQoVLOrzrjrl00KPYQ5VXF4uYX+aXFnimpobmI1fDQkClra12+X6qyTY3DD52PbOnndzgBtgfT32Jg7KHfyYSmdyMRvTptxJc4vs+xT1X2JeWQfyWbCLowXxZFEStb3s9vIlEAznNwPTLKEddPorlXzDTUhaB7nTNX9Cs+3gYHzKw8tKrBPIWSCYI9fwH X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1382;31:Hb2CS293aNj6momvGiasyZsnF8L1COkBQGWGXDDHoLA5m70Eoo8C2Cp8Qztx/CyiOz2A8/e75QLRbwo5P6vmQk7qiu8WLYY58JorikyK1ORZ9NLebs/2CSgyxEJu8qTGh18mbEKzZHHvYkpo87YXE4HHv4njbyAN0ho918KEdKvre0WSjGMbBo8U2WUlT4bc89r1hMzPj+Cofsj9Q4sYLMwyFKxbkPInDeD0CHAC6raGe9Q1/OXyThdI1ICQG6mddh6rRk9ORwKhbRwRSqP3qw==;20:u9WtHFVXje3MSrXaagChtLIZ5SKZhnuXACDpbFHaG/XONIwn+GJ4eQ6k8WDZamnbLaeQhk80I9OFs+NFhISZE0xf8ApZncjff6d4LdzecdaqbXZSmJeiFCrv28WxAQD96bCXRPFfH8p2Vkdo1EZMjttZrng+INfdEht2lFp8xIUvcUCZEmMdbh1QnFh6robWeK5cIkytWNXq++idn948Q0wcLau+ODtobk8tJR4/sAp+8aTE5Qq/O5En+aanuKFx8NxTNKqQTseEIwDLc3+dgLHaV8yWaPdu/8uA5e+EHrgXOG++xTgXJAuj7Doi2nRkuUM57svvZcdBYRPQGYBEwtDkwXF45hgevapsO7U7/Mt/87H22cyKUzPMhghpBzji5YuxheM7P7k2ncLqmE5N0O76efg0MHsVejRKYjISJ4WbSGcOzhRE+QzHQnKEtT3Nh4jj/pR8QKKlnCLak8YXd/CTDWnxyUwu2bJF1L09h6n176GkSAshDA288cuXbu0c X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:CY4PR12MB1382;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1382; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1382;4:nGxwQlKY3a+3LE2v/YKKuXXdA0x/G/IQkyKGbHmg5lggNW1ruvmiI8fI26J7hppb4Wtd/BpGpN3yLC0zL0N632jt9LCVe8+VvHwaqBx4FoTSu1CsrKcA8R4kCltALUvDRSlCMEopTKic9pCB34QW4fOoXPiFatNZUO6wMG3bw1AAG5tzltoVURyXRtPc9oXwuOSL3LuH7oFSXgPPCK0gGWehFOyRfR8fTpqnqqKQRCbFYpixy8+82E+MfwqHDxdY5JnssNAjn/JHpZqFx1GLLbrgKq60HnnG5IQE7HBmLxdz8rXr1dVBj3tSXHiOOcGaeydtxcA6qPt8ji3PKYkIR5XQTG1IgCfZvdnXPgG4woxYseQjD32+xxMKGKszBCaUP6WaAyJ/JmJUhP8vMOuDpeksEV+tdU3R0YLfvEGFPok= X-Forefront-PRVS: 01221E3973 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(105586002)(47776003)(106356001)(66066001)(4001350100001)(46406003)(50466002)(83506001)(229853002)(33646002)(2950100002)(5660300001)(101416001)(76176999)(50986999)(92566002)(54356999)(1076002)(586003)(2201001)(3846002)(6116002)(23726003)(86362001)(97756001)(77096005)(68736007)(9686002)(6666003)(42186005)(97736004)(5001770100001)(189998001)(2906002)(7846002)(81166006)(8676002)(81156014)(4326007)(305945005)(7736002)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1382;H:yaz-fedora.dyhomenet;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR12MB1382;23:L6rE028IDAZtOi3FnUc25DssfOHQZVngyNK6G0HdC?= =?us-ascii?Q?d7tNMlnU1XXaB7Gf7/ZmsiL1MRejhFZbU9rzFy7WZYEM63uVUyjUVk/vo67L?= =?us-ascii?Q?UBoNrgl6sb7pjkQ0vB6EI8P+5G7zxvG93m0iKI/FpKmtnR9cZZOwypryTiqf?= =?us-ascii?Q?DzNJYtFHmwHfy/GAHvv++U9o4lsuCluhvs7xAi3Kx6a3ms1tmun9B1T1vKCU?= =?us-ascii?Q?dz3Pj7EAi8ZRipdUOBx08d860RE9zMRGmEdabl6hdO/nMhiswla8CdSoqLaa?= =?us-ascii?Q?vfo2JTxrj/p+4WEMXlxB0wgSN2n6QXamdxFdzYdwfix+gY5NCKnsaeRGDcU/?= =?us-ascii?Q?yqU09I78jWF70DzW+nTtGS7QCpPfPx8t6a/NOrrHMIjUyXjO8EpjcgaBzaxB?= =?us-ascii?Q?JHOL7iumOCnVQwgLwk1vwWHIATBv0uzr3bwmaTR3S8rEv6Y1OvR4quMXWB1R?= =?us-ascii?Q?qh2G28R5BfMULcJg3/VrGO7/ir7Qt7iuOkUuaMgSauYli626bj2N2FxhVKTk?= =?us-ascii?Q?pXQT/+7beJOx3eYN15LM0q55Z9jU2dyL0M3E+YyAheyc0K3fvt16/59r4i+9?= =?us-ascii?Q?8loTq86DbhFn3jCVCrkaW61SdB8TVQYu5a+VgODJ1HtF0eTjyg8BZn1mg8xH?= =?us-ascii?Q?WMkS3UKRQCL+xsHsde6+1d33fTJ0QASQs0Kp9mwUolajI/lJPm2oJceqaH5C?= =?us-ascii?Q?0rYQlh/yvsTwX+LHRoccAp/uUMQJS0nvdH7sVFYZE0CPW2B0KvKz0U4w40XF?= =?us-ascii?Q?lnHfLeLH66MA9SzJIoomO9e1+52gY/cHdyMzaPc78JRlLoVj3o2mUpdvgHbV?= =?us-ascii?Q?Nc7xcC2ax/LP5otjukHjLUYrcVxS0UgNl+i9PLw1ibUNXo/uy2xTZJp3vPcE?= =?us-ascii?Q?Z0ZfOfOe05aS5nEqykeDov18zwENeCr654m2V+Ij1krAnBkCbPIlY8jjAQB8?= =?us-ascii?Q?eTyFQeiwYNPTFiSaS21GnR0njZss1NCbkCAIZagh6+AcovPw81jEp0y45eXn?= =?us-ascii?Q?DBgqq8wDektwVw+i+5ZDUaWb1iNbTPHF5+/APBApE8L+//mJqIhXLhq2isyi?= =?us-ascii?Q?3PIS8+Dz/roYTnmwXAMqYC8Tygbs1qBlVZOgobnYxAzdaAGFv7g+wBW4xzV6?= =?us-ascii?Q?O/rZto6po9W0/cbsC5EBcGm9245TqD94h8a6Rc4JWkatGPZsOSCSw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1382;6:lWRDNBR67SO1IbWzsvz4VaUAZyceRq9jQJwUAKI5V5rKBMbQ7jtDm1YYTuwLcoor0goFWyf6jBsOncVgPXh8HdPpUoPm07pgRTH3F8UwGuWBL7j8dcjuDLUmLziZDOgs2uR7ytC4CdD2pMbELEKFSntDdZ/qpJSnapi2unE3lPkHwCmMY4HBoWoJ3/qgX68oUqmPnyO5YjM7/RBoO9fesuyIR+TSR3Kg7ThVLiuByBDDlTlrPjDs2btqh1sPR3OyXbwH8vLlRQTyy0P+XKcNppR51nphrbGLpxFxgW3bLeX6CMQzdNvvP+R19ASfOvoblWEYxZl4Lg2CkdK0fPOqBR5iBxs+uGswPS6av52fF3Y=;5:4us1pfaWjSqm5YtqX9HduDR4PDenR+vJzJixE727A8oSoMV0+M8fb43UdfxJ5FCGzp+as9uu9Sf0yhxSIKHUwfWAT7xAWEA69z3hOr39AjwwEtpR68q3DgOaxehJT5npEDBmVMKLAFEdJhZfbGqsdLXP5dk3Y8MPLpXs65AHnZA=;24:GxkhkXv1mHMkQzdDMHDmfaE/OG9qdpJPa6J1Y9Nw5kMAlWH+KV3nCxUOwMgZR3oyuMd2rd8Fjc050C8e88m5wW/sTMmH/Cga0PPyzZ9kmOM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1382;7:bpN6pRPfNsrY/lp98al0cXnR3cFvXe2+OfQwc30a5jUNVjv/geyLeaMdy56CxYPVWKyHVb1J4hX7et5ZnhKid25tmKFwdIzpld9evGQhmXsksiC18yYTdp2Fnd3XMlu3sWPoz5mRkG8BcohZJpCDsc/ls+ckETPrmY2OQj4JLinqXfIi/D7JjT10h2BGdaL37Kv0icy99a6RDKEIsmMVz5pPmZ3dXkIQi/22dHaDLwSRSilWsXeHj6x7bxvbGExb+KjW415knuzJpjatgQB3jjfAKY5+DGxW3XcaVF45xYS/BOORUTW1dYZW6PGldqF+ChCnx6evYEEM27jddmruuVGhgF9Rs8dt6Z0c74uHCLs=;20:JpVJ0WLqzupdOKmIOdihdL0JOT0MGGiko4WaYSiK2CM6mVXodR8mC7S9TKUP+kBhtkdYjXHGNA2h26zVue7fzMqDnmKhzRiXJ79FqzC+fYb0mxaeXvl3aKIBxvgXLoOL6rbv3LHOOo9uKnzSlJudZ0G5fv6LpvrBQXDUgNfo8gZ30jejeqmwYan/9vyzFhvohZd0uToSEdyKf+QVOj8pU1B9agJuKNOcBgNWOy1UPTJ2GAIcyWOQrlYVLBBgsTRA X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2016 17:50:09.6864 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1382 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static void get_smca_bank_info(unsigned int bank) > { > unsigned int i, hwid_mcatype, cpu = smp_processor_id(); > - struct smca_hwid_mcatype *type; > + struct smca_hwid *s_hwid; > u32 high, instance_id; > - u16 hwid, mcatype; > > /* Collect bank_info using CPU 0 for now. */ > if (cpu) > @@ -162,14 +157,13 @@ static void get_smca_bank_info(unsigned int bank) > return; > } > > - hwid = high & MCI_IPID_HWID; > - mcatype = (high & MCI_IPID_MCATYPE) >> 16; > - hwid_mcatype = HWID_MCATYPE(hwid, mcatype); > + hwid_mcatype = HWID_MCATYPE(high & MCI_IPID_HWID, > + (high & MCI_IPID_MCATYPE) >> 16); > Sorry for catching this late, but it seems this change doesn't compile correctly. This causes the value of hwid_mcatype to be incorrect, so we will never match a bank to its type. I see this with GCC 4.8.5 and 5.4.0. There are no warnings or issues when building or booting just that the behavior is incorrect. Disassembly of above change: db: 8b 45 e0 mov -0x20(%rbp),%eax de: 41 89 c4 mov %eax,%r12d e1: 25 00 00 ff 0f and $0xfff0000,%eax e6: 41 c1 ec 10 shr $0x10,%r12d ea: 41 09 c4 or %eax,%r12d Disassembly of original code: 286: 8b 45 d0 mov -0x30(%rbp),%eax 289: 41 89 c5 mov %eax,%r13d 28c: c1 e8 10 shr $0x10,%eax 28f: 41 81 e5 ff 0f 00 00 and $0xfff,%r13d 296: 41 c1 e5 10 shl $0x10,%r13d 29a: 41 09 c5 or %eax,%r13d Adding extra parentheses in HWID_MCATYPE() gives the same assembly as the original code and fixes the behavior. > + hwid_mcatype = HWID_MCATYPE((high & MCI_IPID_HWID)), > + ((high & MCI_IPID_MCATYPE) >> 16)); Thanks, Yazen