From: Steven Rostedt <rostedt@goodmis.org>
To: Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
mingo@redhat.com, Mike Leach <mike.leach@arm.com>,
Tor Jeremiassen <tor@ti.com>,
philippe.langlais@st.com, Nicolas GUION <nicolas.guion@st.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Lyra Zhang <zhang.lyra@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: ??
Date: Fri, 11 Nov 2016 11:01:23 -0500 [thread overview]
Message-ID: <20161111110123.019fc088@gandalf.local.home> (raw)
In-Reply-To: <CAG2=9p_3nLD6MuLXPsbfC8LqK76LbwD3BDRUjX3uEUrijZnYCg@mail.gmail.com>
On Fri, 11 Nov 2016 11:38:45 +0800
Chunyan Zhang <zhang.chunyan@linaro.org> wrote:
What happened to the subject?
> >>> +static void
> >>> +trace_process_export(struct trace_export *export,
> >>> + struct ring_buffer_event *event)
> >>> +{
> >>> + struct trace_entry *entry;
> >>> + unsigned int size = 0;
> >>> +
> >>> + entry = ring_buffer_event_data(event);
> >>> +
> >>> + size = ring_buffer_event_length(event);
> >>> +
> >>> + if (export->write)
> >>> + export->write((char *)entry, size);
> >>
> >> Is there ever going to be a time where export->write wont be set?
> >
> > There hasn't been since only one trace_export (i.e. stm_ftrace) was
> > added in this patch-set , I just wanted to make sure the write() has
> > been set before registering trace_export like what I added in 2/3 of
> > this series.
> >
> >>
> >> And if there is, this can be racy. As in
> >>
> >>
> >> CPU 0: CPU 1:
> >> ------ ------
> >> if (export->write)
> >>
> >> export->write = NULL;
> >
> > Is there going to be this kind of use case? Why some one needs to
> > change export->write() rather than register a new trace_export?
> >
> > I probably haven't understood your point thoroughly, please correct me
> > if my guess was wrong.
> >
>
> Any further comments? :)
I don't remember which patch series this goes to, so right now, no.
-- Steve
next prev parent reply other threads:[~2016-11-11 16:01 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 3:38 Chunyan Zhang
2016-11-11 16:01 ` Steven Rostedt [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-29 13:32 [PATCH v3 2/5] w1_therm: adding sysfs entry to check device power Akira Shimahara
2020-04-29 13:46 ` Greg KH
2020-04-29 13:57 ` _ Akira shimahara
2019-08-30 7:11 [PATCH v6 0/4] support reserving crashkernel above 4G on arm64 kdump Chen Zhou
2019-12-18 2:07 ` Chen Zhou
2019-12-18 17:18 ` John Donnelly
2019-12-19 2:56 ` Chen Zhou
2019-12-19 18:33 ` ` John Donnelly
2019-12-20 1:44 ` ` Chen Zhou
2016-11-15 20:29 Christoph Lameter
2016-11-15 21:58 ` ??? Steven Rostedt
[not found] <CAHjEeniVr6YmfLojEJutcEqk1pX0jTOvFvtJs4WvxQC2bJ4C3g@mail.gmail.com>
2016-06-01 1:13 ` ###$$$@# iutititbpigi
[not found] <CAP9ngMJVJuqWMsfRNTaVQk_2690m1Vic60SRXOb8dzg9i=KEMA@mail.gmail.com>
2015-10-27 20:39 ` ? Amall
2015-09-29 15:58 ! Kathrine
2015-08-01 12:29 ! Rita
2015-08-01 8:50 ! Rita
2013-10-19 7:26 ! Ana Flavia Maria
2013-09-25 12:01 $ FBI
2012-01-01 12:45 ! FBI
2011-01-03 13:45 $ Sgt Moore Paul
2010-11-16 13:59 , Ming-Yang Lee
2010-07-27 7:46 , john erchart
2010-07-24 7:48 , Mr.COOK ADAMS
2010-06-27 18:43 , Mr.COOK ADAMS
2010-06-27 18:01 , Mr.COOK ADAMS
2010-06-27 11:02 , DHL UNIT
2010-06-16 20:30 , SBECKFORD Financial Loan Company
2010-06-16 18:57 , SBECKFORD Financial Loan Company
2010-06-12 9:59 , Mr.COOK ADAMS
2010-02-22 20:25 , JOSE LOANS
2010-02-22 18:39 , JOSE LOANS
2010-02-22 18:17 , JOSE LOANS
2010-02-22 17:53 , JOSE LOANS
2008-03-11 4:31 [PATCH] Move memory controller allocations to their own slabs Balbir Singh
2008-03-11 5:00 ` + KOSAKI Motohiro
2008-03-11 5:07 ` + Balbir Singh
2004-09-30 2:19 ??? Charlie LaMothe
2003-04-25 15:48 :((((((( Balram Adlakha
2003-04-25 15:59 ` :((((((( CaT
2003-04-25 16:08 ` :((((((( Valdis.Kletnieks
2003-04-25 18:07 ` :((((((( Benjamin Herrenschmidt
2002-02-17 2:11 \ Timothy Robinson
2002-02-05 23:48 äÌÑÇÌÁ×ÎÏÇÏÂÕÈÇÁÌÔÅÒÁ au_ru
2002-02-06 21:21 ` ????????????????????? Brian
2002-02-06 22:31 ` ????????????????????? Alex Bligh - linux-kernel
2002-02-06 22:46 ` ????????????????????? Roland Dreier
2002-02-07 11:12 ` ????????????????????? Bruce Harada
2002-02-07 19:59 ` ????????????????????? Pavel Machek
2002-02-06 23:42 ` ????????????????????? Brian
2002-02-07 11:44 ` ????????????????????? David S. Miller
2002-02-07 20:01 ` ????????????????????? Jesse Pollard
2002-02-08 9:57 ` ????????????????????? Horst von Brand
2002-02-07 12:12 ` ????????????????????? Pete Cervasio
2002-02-08 12:40 ` ????????????????????? Martin Dalecki
2002-02-07 12:47 ` ????????????????????? Oliver M . Bolzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161111110123.019fc088@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@arm.com \
--cc=mingo@redhat.com \
--cc=nicolas.guion@st.com \
--cc=philippe.langlais@st.com \
--cc=tor@ti.com \
--cc=zhang.chunyan@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).