* [PATCH] ARM64: dts: bcm2837-rpi-3-b: remove incorrect pwr LED
@ 2016-11-11 17:38 Eric Anholt
2016-11-12 14:41 ` Stefan Wahren
0 siblings, 1 reply; 4+ messages in thread
From: Eric Anholt @ 2016-11-11 17:38 UTC (permalink / raw)
To: Rob Herring
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stephen Warren,
Lee Jones, bcm-kernel-feedback-list, Mark Rutland,
Catalin Marinas, Will Deacon, Andrea Merello, Eric Anholt
From: Andrea Merello <andrea.merello@gmail.com>
We are incorrectly defining the pwr LED, attaching it to a gpio line
that is wired to the Wi-Fi SDIO module (which fails due to this).
The actual power LED is connected to the GPIO expander, which we don't
expose currently.
Thanks-to: Eric Anholt <eric@anholt.net> [for clarifying we can't control the LED]
Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
---
arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts
index 7625e57a64b5..c309633a1e87 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts
@@ -16,13 +16,6 @@
act {
gpios = <&gpio 47 0>;
};
-
- pwr {
- label = "PWR";
- gpios = <&gpio 35 0>;
- default-state = "keep";
- linux,default-trigger = "default-on";
- };
};
};
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM64: dts: bcm2837-rpi-3-b: remove incorrect pwr LED
2016-11-11 17:38 [PATCH] ARM64: dts: bcm2837-rpi-3-b: remove incorrect pwr LED Eric Anholt
@ 2016-11-12 14:41 ` Stefan Wahren
2016-11-15 0:39 ` Eric Anholt
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Wahren @ 2016-11-12 14:41 UTC (permalink / raw)
To: Eric Anholt
Cc: Will Deacon, kraxel, Lee Jones, Andrea Merello, linux-kernel,
Catalin Marinas, bcm-kernel-feedback-list, Mark Rutland,
linux-rpi-kernel, linux-arm-kernel, Rob Herring
Hi Eric,
[add Gerd to CC]
> Eric Anholt <eric@anholt.net> hat am 11. November 2016 um 18:38 geschrieben:
>
>
> From: Andrea Merello <andrea.merello@gmail.com>
>
> We are incorrectly defining the pwr LED, attaching it to a gpio line
> that is wired to the Wi-Fi SDIO module (which fails due to this).
i agree with the intention of this patch, but is the upstream kernel really
affected? I can't see any compatible for the Wifi interface.
>
> The actual power LED is connected to the GPIO expander, which we don't
> expose currently.
>
> Thanks-to: Eric Anholt <eric@anholt.net> [for clarifying we can't control the
> LED]
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
> Signed-off-by: Eric Anholt <eric@anholt.net>
Fixes: 9d56c22a7861 ("ARM: bcm2835: Add devicetree for the Raspberry Pi 3.")
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM64: dts: bcm2837-rpi-3-b: remove incorrect pwr LED
2016-11-12 14:41 ` Stefan Wahren
@ 2016-11-15 0:39 ` Eric Anholt
2016-11-15 10:46 ` Gerd Hoffmann
0 siblings, 1 reply; 4+ messages in thread
From: Eric Anholt @ 2016-11-15 0:39 UTC (permalink / raw)
To: Stefan Wahren
Cc: Will Deacon, kraxel, Lee Jones, Andrea Merello, linux-kernel,
Catalin Marinas, bcm-kernel-feedback-list, Mark Rutland,
linux-rpi-kernel, linux-arm-kernel, Rob Herring
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
Stefan Wahren <stefan.wahren@i2se.com> writes:
> Hi Eric,
>
> [add Gerd to CC]
>
>> Eric Anholt <eric@anholt.net> hat am 11. November 2016 um 18:38 geschrieben:
>>
>>
>> From: Andrea Merello <andrea.merello@gmail.com>
>>
>> We are incorrectly defining the pwr LED, attaching it to a gpio line
>> that is wired to the Wi-Fi SDIO module (which fails due to this).
>
> i agree with the intention of this patch, but is the upstream kernel really
> affected? I can't see any compatible for the Wifi interface.
The wifi isn't in the DT yet because the driver isn't merged. Some
progress was made on that a while ago, but people asked for more
cleanups so it's still living out of tree.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM64: dts: bcm2837-rpi-3-b: remove incorrect pwr LED
2016-11-15 0:39 ` Eric Anholt
@ 2016-11-15 10:46 ` Gerd Hoffmann
0 siblings, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2016-11-15 10:46 UTC (permalink / raw)
To: Eric Anholt
Cc: Stefan Wahren, Will Deacon, Lee Jones, Andrea Merello,
linux-kernel, Catalin Marinas, bcm-kernel-feedback-list,
Mark Rutland, linux-rpi-kernel, linux-arm-kernel, Rob Herring
On Mo, 2016-11-14 at 16:39 -0800, Eric Anholt wrote:
> Stefan Wahren <stefan.wahren@i2se.com> writes:
>
> > Hi Eric,
> >
> > [add Gerd to CC]
> >
> >> Eric Anholt <eric@anholt.net> hat am 11. November 2016 um 18:38 geschrieben:
> >>
> >>
> >> From: Andrea Merello <andrea.merello@gmail.com>
> >>
> >> We are incorrectly defining the pwr LED, attaching it to a gpio line
> >> that is wired to the Wi-Fi SDIO module (which fails due to this).
> >
> > i agree with the intention of this patch, but is the upstream kernel really
> > affected? I can't see any compatible for the Wifi interface.
>
> The wifi isn't in the DT yet because the driver isn't merged. Some
> progress was made on that a while ago, but people asked for more
> cleanups so it's still living out of tree.
some low-hanging fruits (codestyle mostly) are done, but more work is
needed (fix messy timeout handling, make dma work). Didn't happed yet
due to -ENOTIME. My current state is here:
https://www.kraxel.org/cgit/linux/log/?h=bcm2837-wifi
In case anyone wants pick it up feel free to do so (but please tell me
so we avoid duplicating work).
cheers,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-15 10:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-11 17:38 [PATCH] ARM64: dts: bcm2837-rpi-3-b: remove incorrect pwr LED Eric Anholt
2016-11-12 14:41 ` Stefan Wahren
2016-11-15 0:39 ` Eric Anholt
2016-11-15 10:46 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).