From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S964933AbcKNVSY (ORCPT <rfc822;w@1wt.eu>);
        Mon, 14 Nov 2016 16:18:24 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:41254 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S938503AbcKNVSW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 14 Nov 2016 16:18:22 -0500
Date: Mon, 14 Nov 2016 16:18:18 -0500 (EST)
Message-Id: <20161114.161818.1460191406108019273.davem@davemloft.net>
To: alex.g@adaptrum.com
Cc: f.fainelli@gmail.com, gokhan@adaptrum.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if
 needed
From: David Miller <davem@davemloft.net>
In-Reply-To: <1478993533-1936-1-git-send-email-alex.g@adaptrum.com>
References: <1478993533-1936-1-git-send-email-alex.g@adaptrum.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 14 Nov 2016 12:18:52 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Alexandru Gagniuc <alex.g@adaptrum.com>
Date: Sat, 12 Nov 2016 15:32:13 -0800

> +	if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
> +		ret = vsc8601_add_skew(phydev);

I think you should use phy_interface_is_rgmii() here.