From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934321AbcKNPpZ (ORCPT ); Mon, 14 Nov 2016 10:45:25 -0500 Received: from smtprelay0107.hostedemail.com ([216.40.44.107]:53207 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934309AbcKNPon (ORCPT ); Mon, 14 Nov 2016 10:44:43 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:334:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:2691:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3872:3874:5007:6119:6261:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12438:12740:12760:13069:13311:13357:13439:14181:14659:14721:21080:21212:21324:30029:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: cake81_27dc2eb2b9140 X-Filterd-Recvd-Size: 1700 Date: Mon, 14 Nov 2016 10:44:32 -0500 From: Steven Rostedt To: Russell King - ARM Linux Cc: Rabin Vincent , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rabin Vincent Subject: Re: [PATCH] ARM: ftrace: fix syscall name matching Message-ID: <20161114104432.3bd2fb2c@gandalf.local.home> In-Reply-To: <20161114104008.36e9c40d@gandalf.local.home> References: <1479128625-20948-1-git-send-email-rabin.vincent@axis.com> <20161114134017.GJ1041@n2100.armlinux.org.uk> <20161114104008.36e9c40d@gandalf.local.home> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Nov 2016 10:40:08 -0500 Steven Rostedt wrote: > > Is this really safe? What guarantees that we can wind forward four > > bytes here? If it's always safe, it needs a better comment than just > > two words. > > I believe it is, but a comment would do well. Also, the generic function that is called if the arch does not define ARCH_HAS_SYSCALL_MATCH_SYM_NAME does this too. return !strcmp(sym + 3, name + 3); And looking at this, it really should be + 4 and not + 3, because it doesn't match the comment above, where it says it can handle both ".SyS" and "SyS", but it doesn't handle ".SyS" compared to ".sys". -- Steve