From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932620AbcKNOty (ORCPT ); Mon, 14 Nov 2016 09:49:54 -0500 Received: from mga02.intel.com ([134.134.136.20]:57529 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932414AbcKNOtu (ORCPT ); Mon, 14 Nov 2016 09:49:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,638,1473145200"; d="scan'208";a="1068244219" Date: Mon, 14 Nov 2016 06:49:44 -0800 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Andi Kleen , Jin Yao , jolsa@kernel.org, Linux-kernel@vger.kernel.org, kan.liang@intel.com Subject: Re: [PATCH v4 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view Message-ID: <20161114144944.GA20031@tassilo.jf.intel.com> References: <1477876794-30749-1-git-send-email-yao.jin@linux.intel.com> <20161114143056.GD27058@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161114143056.GD27058@kernel.org> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 14, 2016 at 11:30:56AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 31, 2016 at 09:19:48AM +0800, Jin Yao escreveu: > > v4: Update according to Andi's comments. The requirement is not displaying > > the number of removed loops. It needs to display the average number of > > iterations. It computes out the number of iterations by counting > > the removed loops. > > > > v3: 1. Display the count for tsx abort, remove the abort percentage. > > > > 2. Since the branch history code has a loop detection that removes > > small loops in util/machine.c:remove_loops(). It would be nice to > > note how many loops were removed. So it adds the note on some > > callchain entries. > > > > v2: Just a rebase to Arnaldo's perf/core branch, no functional changes. > > Andi, are you ok with this now? Can I have your Acked-by or Tested-by? Yes it looks good to me now. Acked-by: Andi Kleen -Andi