From: Peter Zijlstra <peterz@infradead.org>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Zhang Rui <rui.zhang@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
"Chen, Yu C" <yu.c.chen@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Petr Mladek <pmladek@suse.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH 3/3] thermal/powerclamp: use PF_IDLE in injection kthread
Date: Mon, 14 Nov 2016 16:11:05 +0100 [thread overview]
Message-ID: <20161114151105.GH3142@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1478718312-12847-4-git-send-email-jacob.jun.pan@linux.intel.com>
On Wed, Nov 09, 2016 at 11:05:12AM -0800, Jacob Pan wrote:
> +static enum hrtimer_restart idle_inject_timer_fn(struct hrtimer *hrtimer)
> +{
> + set_tsk_need_resched(current);
So drivers really should not use this, which is why I had that in
play_idle().
> + return HRTIMER_NORESTART;
> +}
> +
> static void clamp_idle_injection_func(struct kthread_work *work)
> {
> struct powerclamp_worker_data *w_data;
> - unsigned long target_jiffies;
> + unsigned long end_time;
> + unsigned int duration_ms;
>
> w_data = container_of(work, struct powerclamp_worker_data,
> idle_injection_work.work);
>
> + hrtimer_init(&w_data->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_PINNED);
> + w_data->timer.function = idle_inject_timer_fn;
> +
> /*
> * only elected controlling cpu can collect stats and update
> * control parameters.
> @@ -453,31 +459,17 @@ static void clamp_idle_injection_func(struct kthread_work *work)
> if (should_skip)
> goto balance;
>
> + end_time = jiffies + w_data->duration_jiffies;
> + duration_ms = jiffies_to_msecs(w_data->duration_jiffies);
> + hrtimer_start(&w_data->timer, ms_to_ktime(duration_ms),
> + HRTIMER_MODE_REL_PINNED);
> +
> + cpuidle_use_deepest_state(true);
> + while (time_after(end_time, jiffies))
> + play_idle();
Why that loop?
> + cpuidle_use_deepest_state(false);
> +
> + hrtimer_cancel(&w_data->timer);
prev parent reply other threads:[~2016-11-14 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 19:05 [PATCH 0/3] Stop sched tick in idle injection task Jacob Pan
2016-11-09 19:05 ` [PATCH 1/3] idle: add support for tasks that inject idle Jacob Pan
2016-11-14 14:57 ` Peter Zijlstra
2016-11-14 15:01 ` Peter Zijlstra
2016-11-14 15:01 ` Peter Zijlstra
2016-11-14 16:20 ` Jacob Pan
2016-11-14 16:22 ` Peter Zijlstra
2016-11-14 16:29 ` Jacob Pan
2016-11-09 19:05 ` [PATCH 2/3] cpuidle: allow setting deepest idle Jacob Pan
2016-11-14 14:58 ` Peter Zijlstra
2016-11-09 19:05 ` [PATCH 3/3] thermal/powerclamp: use PF_IDLE in injection kthread Jacob Pan
2016-11-14 15:11 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114151105.GH3142@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arjan@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).