From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753154AbcKOS05 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 15 Nov 2016 13:26:57 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:56252 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751599AbcKOS0y (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 15 Nov 2016 13:26:54 -0500
Date: Tue, 15 Nov 2016 19:27:04 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH] lkdtm: Prevent the compiler from optimising
 lkdtm_CORRUPT_STACK()
Message-ID: <20161115182704.GA29239@kroah.com>
References: <1479193352-486-1-git-send-email-mpe@ellerman.id.au>
 <CAGXu5j+V=+-=WHmc=XMDCRLovya7ZRkiu8p9znjOkRFWPNq5Rw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGXu5j+V=+-=WHmc=XMDCRLovya7ZRkiu8p9znjOkRFWPNq5Rw@mail.gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 15, 2016 at 09:27:47AM -0800, Kees Cook wrote:
> On Mon, Nov 14, 2016 at 11:02 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> > At least on powerpc with GCC 6, the compiler is smart enough to optimise
> > lkdtm_CORRUPT_STACK() into an empty function that just returns.
> 
> Sneaky. Thanks!
> 
> > If we print the buffer after we've written to it that prevents the
> > compiler from optimising away data and the memset().
> >
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> 
> Acked-by: Kees Cook <keescook@chromium.org>
> 
> Greg, can you add this to the drivers/misc?

Now added, thanks.

greg k-h