From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754022AbcKPPh6 (ORCPT ); Wed, 16 Nov 2016 10:37:58 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:52566 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbcKPPh5 (ORCPT ); Wed, 16 Nov 2016 10:37:57 -0500 From: Arnd Bergmann To: Felipe Balbi , Greg Kroah-Hartman Cc: Arnd Bergmann , John Youn , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: dwc3: avoid empty-body warning Date: Wed, 16 Nov 2016 16:37:30 +0100 Message-Id: <20161116153742.3663212-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:cwNe23AzgVOJ8DFYM4TRzFkSpK4Kza7H/57wQsNNBQp7pfBzI1D kLC6ys9E7rRPqZB30DcM/eIVQDx6cJW9ri1B4TtTboGSwbIcOX04xnTkHpaTsMzJcdS2qkA o7nbqd2Du+V5vbZuoB8HzFu6QER+EnKfsw3yAvpYiWw3Er+14IrlM0DDFuZismwScuHNkJC STP+4njq2DIC7GBvfVbIg== X-UI-Out-Filterresults: notjunk:1;V01:K0:34OYIg/Z684=:/Zcc6C43PP0YKVpn8HS9jJ s2g8pww056aMX0Jp+3+KVNC9f7wgz9sp8lGUXRBd4DrmkdZPo9bT0PUiZAZSiM8PQC8xCnx19 KDpmMDY0xdStg+Xb/RMdWyl5/74mNwl2CKvCWKIb763n69Lva95cvYsV5Y6YHWxs4GpKrSQdD AJLLTsG45SzhzTZKUqtCGvicC9nL4PqfCmM0617NCvUv3+jK/yc8RYXO0dB1C7Zt7vbmEPRJ2 PO7JM3MPsAKv3W+Dc9xVXwF/EFaNZng0hcCINU9KlXx3Zw3udSAnJlVP6la9E6DR6YsM3gsXV ZnGZE+cHOMs0r3gSquGHZOXoD66TTM7P0XFzzhBeAf07Brj6ALCVhVRK1GpD3irzTYPFb6du0 xb/H2FIX+CcjJOSM8ZFQD+k5UjdqJZmAGBH0IG1Q7eWeFHtaTI24P4/EqByEhcdagXM3a21ao SbMQcSbSXof17m6LyljCo7YTo73BtNtM05r6073Tf2AS9X7+nK17nsgcx8Q7xuIlfR09WBoLM bbv/eetN8PQj1P586ZO3X/gMg5QCJ4ScPiNzwviae7kLOY3B2+10t4sIPned5cjS16XdVkk2q s8VAw4PClJZoCDSfqodm1thmCmRF3rAOgt2pKO25Mmt1mvbzE+UDB0CpAsyS0y/bPAS3qRLHa AEl6a2xRnXxQ+fnHJrZGdmqhYpaKF0cBSZh8TFdE5euNYh2KLqAPlg22TdI2N/wSbQHQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Building with W=1, we get a warning about harmless empty statements: drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_handle_intf': drivers/usb/dwc3/ep0.c:491:4: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] gcc does not warn about {} here, so maybe use that instead. Alternatively, the code could be removed entirely as it does nothing. Signed-off-by: Arnd Bergmann --- This has been present in the driver for a while, but the code just moved around, so it showed up as a new warning for me. I hope to eventually address all W=1 warnings as they tend to find real bugs elsewhere and we may as well fix it now that the code has changed. --- drivers/usb/dwc3/ep0.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index 2b22ea7263d8..1e93cfc8f88b 100644 --- a/drivers/usb/dwc3/ep0.c +++ b/drivers/usb/dwc3/ep0.c @@ -486,12 +486,12 @@ static int dwc3_ep0_handle_intf(struct dwc3 *dwc, switch (wValue) { case USB_INTRF_FUNC_SUSPEND: - if (wIndex & USB_INTRF_FUNC_SUSPEND_LP) + if (wIndex & USB_INTRF_FUNC_SUSPEND_LP) { /* XXX enable Low power suspend */ - ; - if (wIndex & USB_INTRF_FUNC_SUSPEND_RW) + } + if (wIndex & USB_INTRF_FUNC_SUSPEND_RW) { /* XXX enable remote wakeup */ - ; + } break; default: ret = -EINVAL; -- 2.9.0