From: Borislav Petkov <bp@suse.de>
To: Yu-cheng Yu <yu-cheng.yu@intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
David Hansen <dave.hansen@linux.intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>
Subject: Re: [PATCH] x86/fpu: Fix invalid FPU ptrace state after execve
Date: Wed, 16 Nov 2016 18:54:37 +0100 [thread overview]
Message-ID: <20161116175437.wfph6ee5zmsyzqwz@pd.tnic> (raw)
In-Reply-To: <1479315396-2131-1-git-send-email-yu-cheng.yu@intel.com>
On Wed, Nov 16, 2016 at 08:56:36AM -0800, Yu-cheng Yu wrote:
> Robert O'Callahan reported that after an execve PTRACE_GETREGSET
> NT_X86_XSTATE continues to return the pre-exec register values
> until the exec'ed task modifies FPU state. The test code is at
> https://bugzilla.redhat.com/attachment.cgi?id=1164286.
>
> What is happening is when eagerfpu is enabled, fpu__clear() did
> not properly clear fpstate. Fix it by doing just that.
>
> Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
> Reported-by: Robert O'Callahan <robert@ocallahan.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: David Hansen <dave.hansen@linux.intel.com>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: "Ravi V. Shankar" <ravi.v.shankar@intel.com>
> ---
> arch/x86/kernel/fpu/core.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/x86/kernel/fpu/core.c b/arch/x86/kernel/fpu/core.c
> index 4700401..4c203c4 100644
> --- a/arch/x86/kernel/fpu/core.c
> +++ b/arch/x86/kernel/fpu/core.c
> @@ -521,14 +521,14 @@ void fpu__clear(struct fpu *fpu)
> {
> WARN_ON_FPU(fpu != ¤t->thread.fpu); /* Almost certainly an anomaly */
>
> - if (!use_eager_fpu() || !static_cpu_has(X86_FEATURE_FPU)) {
> - /* FPU state will be reallocated lazily at the first use. */
> - fpu__drop(fpu);
> - } else {
> - if (!fpu->fpstate_active) {
> - fpu__activate_curr(fpu);
> - user_fpu_begin();
> - }
> + fpu__drop(fpu);
> +
> + /*
> + * When eagerfpu is used, make sure fpstate is cleared and initialized.
> + */
> + if (use_eager_fpu()) {
c592b5734706 ("x86/fpu: Remove use_eager_fpu()")
Please redo this patch against tip/master.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2016-11-16 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 16:56 [PATCH] x86/fpu: Fix invalid FPU ptrace state after execve Yu-cheng Yu
2016-11-16 17:54 ` Borislav Petkov [this message]
2016-11-17 21:31 ` Dave Hansen
2016-11-17 22:18 ` Yu-cheng Yu
2016-11-21 9:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161116175437.wfph6ee5zmsyzqwz@pd.tnic \
--to=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).