From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754068AbcKPSre (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Nov 2016 13:47:34 -0500
Received: from mail.skyhub.de ([78.46.96.112]:40976 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750928AbcKPSra (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Nov 2016 13:47:30 -0500
Date: Wed, 16 Nov 2016 19:47:26 +0100
From: Borislav Petkov <bp@alien8.de>
To: Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH] Support for perf on AMD family17h processors
Message-ID: <20161116184726.4rkhsoxx35mr7pdz@pd.tnic>
References: <1479315713-11115-1-git-send-email-Janakarajan.Natarajan@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1479315713-11115-1-git-send-email-Janakarajan.Natarajan@amd.com>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 16, 2016 at 11:01:53AM -0600, Janakarajan Natarajan wrote:
> This patch enables perf core PMU support for AMD family17h processors.
> In family17h, there is no PMC-event constraint. All events, irrespective
> of the type, can be measured using any of the performance counters.
> 
> Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
> ---
>  arch/x86/events/amd/core.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
> index f5f4b3f..849688d 100644
> --- a/arch/x86/events/amd/core.c
> +++ b/arch/x86/events/amd/core.c
> @@ -652,7 +652,11 @@ static __initconst const struct x86_pmu amd_pmu = {
>  	.amd_nb_constraints	= 1,
>  };
>  
> -static int __init amd_core_pmu_init(void)
> +/*
> + * This function initializes core PMU to enable support
> + * for AMD Core PMC Extension.
> + */
> +static int __init amd_core_pmc_ext_init(void)
>  {
>  	if (!boot_cpu_has(X86_FEATURE_PERFCTR_CORE))
>  		return 0;

This renaming looks pretty useless to me. So does the comment.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.