From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754269AbcKPWXv (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Nov 2016 17:23:51 -0500
Received: from smtp.codeaurora.org ([198.145.29.96]:48570 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753891AbcKPWXt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Nov 2016 17:23:49 -0500
DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 57DD8614A5
Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org
Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org
Date: Wed, 16 Nov 2016 14:23:47 -0800
From: Stephen Boyd <sboyd@codeaurora.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Rajendra Nayak <rnayak@codeaurora.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write
Message-ID: <20161116222347.GL25626@codeaurora.org>
References: <1479218682-15948-1-git-send-email-vivek.gautam@codeaurora.org>
 <20161115185922.GB25626@codeaurora.org>
 <CAFp+6iEsTpga9pTgCwP=q4LG42QUhgBUih+0jH1eKp-NA7cLDw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFp+6iEsTpga9pTgCwP=q4LG42QUhgBUih+0jH1eKp-NA7cLDw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/16, Vivek Gautam wrote:
> Hi Stephen,
> 
> On Wed, Nov 16, 2016 at 12:29 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 11/15, Vivek Gautam wrote:
> >> @@ -53,7 +53,7 @@ static int qfprom_remove(struct platform_device *pdev)
> >>  static struct nvmem_config econfig = {
> >>       .name = "qfprom",
> >>       .owner = THIS_MODULE,
> >> -     .stride = 4,
> >> +     .stride = 1,
> >
> > Are we certain that all qfproms support byte accesses?
> 
> I have tested on 8916 and 8996. Will give a try on older targets as
> well.
> 
> For a note: we had been using the reg_stride = 1, before removing
> regmap support for nvmem access [1].
> 
> [1] 382c62f nvmem: qfprom: remove nvmem regmap dependency
> 
> 

Ah ok. If we were doing byte accesses before then I have no
concerns.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project