From: Dan Carpenter <dan.carpenter@oracle.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 12/19] staging: lustre: libcfs: remove == 0 testing
Date: Fri, 18 Nov 2016 14:01:27 +0300 [thread overview]
Message-ID: <20161118105235.GB6266@mwanda> (raw)
In-Reply-To: <1479411357-28979-13-git-send-email-jsimmons@infradead.org>
On Thu, Nov 17, 2016 at 02:35:50PM -0500, James Simmons wrote:
> Testing == 0 is not kernel style so remove this
> type of testing from libcfs.
>
That's not true. Checkpatch.pl won't complain.
Not everyone has thought about it or agrees with me but there are time
when == 0 is idiomatic. For example, if you are talking about the
*number* zero then it should probably be == 0. If it's like "rc == 0"
then "rc" doesn't mean the number it means success/fail so it should be
"if (!rc) ". But it's intuitive to say "if (len == 0) ".
The other place is strcmp() and friends where it's much more intuitive:
strcmp(a, b) == 0 means a == b
strcmp(a, b) < 0 means a < b
strcmp(a, b) != 0 means a != b
regards,
dan carpenter
next prev parent reply other threads:[~2016-11-18 11:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 19:35 [PATCH 00/19] LNet/libcfs checkpatch and style cleanups James Simmons
2016-11-17 19:35 ` [PATCH 01/19] staging: lustre: lnet: don't use bare unsigned James Simmons
2016-11-17 19:35 ` [PATCH 02/19] staging: lustre: lnet: resolve trailing */ errors James Simmons
2016-11-17 19:35 ` [PATCH 03/19] staging: lustre: libcfs: use static const char const * for a suffixes array James Simmons
2016-11-17 19:35 ` [PATCH 04/19] staging: lustre: libcfs: remove explicit test of NULL variable James Simmons
2016-11-17 19:35 ` [PATCH 05/19] staging: lustre: libcfs: fix aligment issue James Simmons
2016-11-17 19:35 ` [PATCH 06/19] staging: lustre: lnet: fix misspelled word destroy James Simmons
2016-11-17 19:35 ` [PATCH 07/19] staging: lustre: lnet: remove unused lib_me_dump James Simmons
2016-11-17 19:35 ` [PATCH 08/19] staging: lustre: lnet: missing blank line after declaration James Simmons
2016-11-17 19:35 ` [PATCH 09/19] staging: lustre: lnet: fill in real lnet_md_t James Simmons
2016-11-17 19:35 ` [PATCH 10/19] staging: lustre: lnet: replace uninitialized_var James Simmons
2016-11-17 19:35 ` [PATCH 11/19] staging: lustre: libcfs: remove != 0 testing James Simmons
2016-11-17 19:35 ` [PATCH 12/19] staging: lustre: libcfs: remove == " James Simmons
2016-11-18 11:01 ` Dan Carpenter [this message]
2016-11-18 16:46 ` James Simmons
2016-11-17 19:35 ` [PATCH 13/19] staging: lustre: libcfs: white space cleanup James Simmons
2016-11-17 19:35 ` [PATCH 14/19] staging: lustre: libcfs: fix misspelling of descriptor James Simmons
2016-11-17 19:35 ` [PATCH 15/19] staging: lustre: libcfs: Make char * array envp static constant James Simmons
2016-11-17 19:35 ` [PATCH 16/19] staging: lustre: libcfs: use pr_* instead of printk James Simmons
2016-11-17 19:35 ` [PATCH 17/19] staging: lustre: libcfs: remove use of __u* types James Simmons
2016-11-17 19:35 ` [PATCH 18/19] staging: lustre: lnet: use BIT macro in LNet selftest James Simmons
2016-11-17 19:35 ` [PATCH 19/19] staging: lustre: lnet: cleanup some of the > 80 line issues James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118105235.GB6266@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).