From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753270AbcKRL25 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 18 Nov 2016 06:28:57 -0500
Received: from merlin.infradead.org ([205.233.59.134]:45652 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753239AbcKRL2z (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 18 Nov 2016 06:28:55 -0500
Date: Fri, 18 Nov 2016 12:28:50 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "Liang, Kan" <kan.liang@intel.com>, Andi Kleen <andi@firstfloor.org>,
        Vince Weaver <vince@deater.net>, lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] perf/x86/uncore: Allow single pmu/box within events group
Message-ID: <20161118112850.GO3117@twins.programming.kicks-ass.net>
References: <20161118001528.GA28231@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161118001528.GA28231@krava>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 18, 2016 at 01:15:28AM +0100, Jiri Olsa wrote:
> Current uncore_validate_group code expects all events within
> the group to have same pmu.
> 
> This leads to constraint code using wrong boxes which leads
> in my case to touching uninitialized spinlocks, but could
> be probably worse.. depends on type and box details.
> 
> I get lockdep warning below for following perf stat:
>   # perf stat -vv -e '{uncore_cbox_0/config=0x0334/,uncore_qpi_0/event=1/}' -a sleep 1

Hurm, we shouldn't be allowing that in the first place I think.


Let me stare at the generic group code, the intent was to only allow
software events to mix with hw events, nothing else.