From: Daniel Vetter <daniel@ffwll.ch>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Thierry Reding <treding@nvidia.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] vgaarb: Downgrade userspace-triggerable messages to debug
Date: Fri, 18 Nov 2016 16:30:05 +0100 [thread overview]
Message-ID: <20161118153005.hqyknhhdcxmmpdkq@phenom.ffwll.local> (raw)
In-Reply-To: <20161118141158.32415.71438.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Fri, Nov 18, 2016 at 08:11:58AM -0600, Bjorn Helgaas wrote:
> To avoid userspace-triggerable dmesg spam, downgrade messages in the sysfs
> write parsing code to debug level.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Applied to drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/vga/vgaarb.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
> index 3a8e9c6..f1312a9 100644
> --- a/drivers/gpu/vga/vgaarb.c
> +++ b/drivers/gpu/vga/vgaarb.c
> @@ -1196,9 +1196,9 @@ static ssize_t vga_arb_write(struct file *file, const char __user *buf,
> }
> pdev = pci_get_domain_bus_and_slot(domain, bus, devfn);
> if (!pdev) {
> - pr_err("invalid PCI address %04x:%02x:%02x.%x\n",
> - domain, bus, PCI_SLOT(devfn),
> - PCI_FUNC(devfn));
> + pr_debug("invalid PCI address %04x:%02x:%02x.%x\n",
> + domain, bus, PCI_SLOT(devfn),
> + PCI_FUNC(devfn));
> ret_val = -ENODEV;
> goto done;
> }
> @@ -1212,7 +1212,7 @@ static ssize_t vga_arb_write(struct file *file, const char __user *buf,
> pr_debug("vgadev %p\n", vgadev);
> if (vgadev == NULL) {
> if (pdev) {
> - vgaarb_err(&pdev->dev, "not a VGA device\n");
> + vgaarb_dbg(&pdev->dev, "not a VGA device\n");
> pci_dev_put(pdev);
> }
>
> @@ -1232,7 +1232,7 @@ static ssize_t vga_arb_write(struct file *file, const char __user *buf,
> }
> }
> if (i == MAX_USER_CARDS) {
> - vgaarb_err(&pdev->dev, "maximum user cards (%d) number reached, ignoring this one!\n",
> + vgaarb_dbg(&pdev->dev, "maximum user cards (%d) number reached, ignoring this one!\n",
> MAX_USER_CARDS);
> pci_dev_put(pdev);
> /* XXX: which value to return? */
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2016-11-18 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 14:11 [PATCH] vgaarb: Downgrade userspace-triggerable messages to debug Bjorn Helgaas
2016-11-18 15:30 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118153005.hqyknhhdcxmmpdkq@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=bhelgaas@google.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).