From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbcKSUy6 (ORCPT ); Sat, 19 Nov 2016 15:54:58 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:41976 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753273AbcKSUy4 (ORCPT ); Sat, 19 Nov 2016 15:54:56 -0500 Date: Sat, 19 Nov 2016 12:54:54 -0800 From: Guenter Roeck To: Michael Walle Cc: linux-hwmon@vger.kernel.org, Jean Delvare , linux-kernel@vger.kernel.org Subject: Re: [RFC,2/2] hwmon: adt7411: add min, max and alarm attributes Message-ID: <20161119205454.GA14249@roeck-us.net> References: <1476438215-6654-2-git-send-email-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476438215-6654-2-git-send-email-michael@walle.cc> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 14, 2016 at 11:43:35AM +0200, Michael Walle wrote: > This patch adds support for the min, max and alarm attributes of the > voltage and temperature channels. Additionally, the temp2_fault attribute > is supported which indicates a fault of the external temperature diode. > > Signed-off-by: Michael Walle > --- > drivers/hwmon/adt7411.c | 306 ++++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 271 insertions(+), 35 deletions(-) > > diff --git a/drivers/hwmon/adt7411.c b/drivers/hwmon/adt7411.c > index 2f44cdc..c6351b8 100644 > --- a/drivers/hwmon/adt7411.c > +++ b/drivers/hwmon/adt7411.c [ ... ] > static int adt7411_read_in_vdd(struct device *dev, u32 attr, long *val) > { > struct adt7411_data *data = dev_get_drvdata(dev); > @@ -179,32 +242,40 @@ static int adt7411_read_in_vdd(struct device *dev, u32 attr, long *val) > return ret; > *val = ret * 7000 / 1024; > return 0; > + case hwmon_in_min: > + ret = i2c_smbus_read_byte_data(client, ADT7411_REG_VDD_LOW); > + if (ret < 0) > + return ret; > + *val = ret * 7000 / 256; > + return 0; > + case hwmon_in_max: > + ret = i2c_smbus_read_byte_data(client, ADT7411_REG_VDD_HIGH); > + if (ret < 0) > + return ret; > + *val = ret * 7000 / 256; return 0; > + case hwmon_in_alarm: > + return adt7411_read_in_alarm(dev, 0, val); > default: > return -EOPNOTSUPP; > } > }