linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Juri Lelli <Juri.Lelli@arm.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	Rafael Wysocki <rjw@rjwysocki.net>,
	Ingo Molnar <mingo@redhat.com>,
	linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Robin Randhawa <robin.randhawa@arm.com>,
	Steve Muckle <smuckle.linux@gmail.com>,
	tkjos@google.com, Morten Rasmussen <morten.rasmussen@arm.com>
Subject: Re: [PATCH] cpufreq: schedutil: add up/down frequency transition rate limits
Date: Mon, 21 Nov 2016 13:26:22 +0100	[thread overview]
Message-ID: <20161121122622.GC3092@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20161121121432.GK24383@e106622-lin>

On Mon, Nov 21, 2016 at 12:14:32PM +0000, Juri Lelli wrote:
> On 21/11/16 11:19, Peter Zijlstra wrote:

> > So no tunables and rate limits here at all please.
> > 
> > During LPC we discussed the rampup and decay issues and decided that we
> > should very much first address them by playing with the PELT stuff.
> > Morton was going to play with capping the decay on the util signal. This
> > should greatly improve the ramp-up scenario and cure some other wobbles.
> > 
> > The decay can be set by changing the over-all pelt decay, if so desired.
> > 
> 
> Do you mean we might want to change the decay (make it different from
> ramp-up) once for all, or maybe we make it tunable so that we can
> address different power/perf requirements?

So the limited decay would be the dominant factor in ramp-up time,
leaving the regular PELT period the dominant factor for ramp-down.

(Note that the decay limit would only be applied on the per-task signal,
not the accumulated signal.)

It could be an option, for some, to build the kernel with a PELT window
of 16ms or so (half its current size), this of course means regenerating
all the constants etc.. And this very much is a compile time thing.

We could fairly easy; if this is so desired; make the PELT window size a
CONFIG option (hidden by default).

But like everything; patches should come with numbers justifying them
etc..

> > Also, there was the idea of; once the above ideas have all been
> > explored; tying the freq ram rate to the power curve.
> > 
> 
> Yep. That's an interesting one to look at, but it might require some
> time.

Sure, just saying that we should resist knobs until all other avenues
have been explored. Never start with a knob.

  reply	other threads:[~2016-11-21 12:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17  5:18 [PATCH] cpufreq: schedutil: add up/down frequency transition rate limits Viresh Kumar
2016-11-21 10:08 ` Viresh Kumar
2016-11-21 10:19   ` Peter Zijlstra
2016-11-21 10:48     ` Viresh Kumar
2016-11-21 11:12       ` Peter Zijlstra
2016-11-21 11:30         ` Viresh Kumar
2016-11-21 11:48           ` Peter Zijlstra
2016-11-21 12:14     ` Juri Lelli
2016-11-21 12:26       ` Peter Zijlstra [this message]
2016-11-21 13:53         ` Juri Lelli
2016-11-21 14:17           ` Peter Zijlstra
2016-11-21 14:37             ` Juri Lelli
2016-11-21 14:43               ` Peter Zijlstra
2016-11-21 14:59                 ` Juri Lelli
2016-11-22  9:27               ` Vincent Guittot
2016-11-22 11:03                 ` Patrick Bellasi
2016-11-21 14:59           ` Patrick Bellasi
2016-11-21 15:26             ` Peter Zijlstra
2016-11-21 15:34               ` Peter Zijlstra
2016-11-21 16:24               ` Patrick Bellasi
2016-11-21 16:46                 ` Peter Zijlstra
2016-11-21 20:53                   ` Rafael J. Wysocki
2016-12-29  3:24         ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161121122622.GC3092@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=Juri.Lelli@arm.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=morten.rasmussen@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=robin.randhawa@arm.com \
    --cc=smuckle.linux@gmail.com \
    --cc=tkjos@google.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).