From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754223AbcKUQ57 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 21 Nov 2016 11:57:59 -0500
Received: from bombadil.infradead.org ([198.137.202.9]:45272 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753156AbcKUQ55 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 21 Nov 2016 11:57:57 -0500
Date: Mon, 21 Nov 2016 08:57:52 -0800
From: Christoph Hellwig <hch@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Binoy Jayan <binoy.jayan@linaro.org>, linux-rdma@vger.kernel.org,
        Mustafa Ismail <mustafa.ismail@intel.com>,
        Lijun Ou <oulijun@huawei.com>,
        Nicholas Bellinger <nab@linux-iscsi.org>,
        Leon Romanovsky <leonro@mellanox.com>, target-devel@vger.kernel.org,
        Tatyana E Nikolova <tatyana.e.nikolova@intel.com>,
        Doug Ledford <dledford@redhat.com>,
        Jenny Derzhavetz <jennyf@mellanox.com>,
        Sagi Grimberg <sagi@grimberg.me>, Sean Hefty <sean.hefty@intel.com>,
        Faisal Latif <faisal.latif@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        linux-kernel@vger.kernel.org,
        "Wei Hu(Xavier)" <xavier.huwei@huawei.com>,
        Mark Brown <broonie@kernel.org>, Mark Bloch <markb@mellanox.com>,
        Steve Wise <swise@opengridcomputing.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Bart Van Assche <bart.vanassche@sandisk.com>,
        Matan Barak <matanb@mellanox.com>, Sagi Grimberg <sagig@mellanox.com>
Subject: Re: [PATCH v5 2/9] IB/core: Replace semaphore sm_sem with an atomic
 wait
Message-ID: <20161121165752.GA12866@infradead.org>
References: <1479708496-9828-1-git-send-email-binoy.jayan@linaro.org>
 <1479708496-9828-3-git-send-email-binoy.jayan@linaro.org>
 <CA+55aFxGjaqduhRCyk0mVxEA7aqQ-omdG8SBreZ=x5cW2ovngQ@mail.gmail.com>
 <4374986.OFD8bCgUa1@wuerfel>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4374986.OFD8bCgUa1@wuerfel>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 21, 2016 at 05:52:27PM +0100, Arnd Bergmann wrote:
> I think a mutex would't work here, since fops->open() and fops->close()
> are not called from the same context and lockdep will complain
> about that.
> 
> Version of the series had replaced the semaphore with a completion
> here, which worked correctly, but one reviewer suggested using
> the wait_event() instead since it's confusing to have a completion
> starting out in 'completed' state.

On the other hand the existing semaphore works perfectly fine, and
is way easier to understand than any of the other models, which also
don't provide any benefit at all.

Please stop messing with perfectly fine semaphores now - there are
plenty that are much better replaced with mutexes or completions,
but this (and various others are not).  Leave them alone and do
something useful instead.