From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753368AbcKVHAw (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Nov 2016 02:00:52 -0500
Received: from mail-pg0-f68.google.com ([74.125.83.68]:34286 "EHLO
        mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751579AbcKVHAu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Nov 2016 02:00:50 -0500
Date: Tue, 22 Nov 2016 15:59:38 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCHSET 0/7] perf sched: Introduce timehist command, again (v2)
Message-ID: <20161122065938.GC10108@danjae.aot.lge.com>
References: <20161116060634.28477-1-namhyung@kernel.org>
 <20161116153428.GA4321@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20161116153428.GA4321@krava>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jiri,

On Wed, Nov 16, 2016 at 04:34:28PM +0100, Jiri Olsa wrote:
> On Wed, Nov 16, 2016 at 03:06:26PM +0900, Namhyung Kim wrote:
> > Hello,
> > 
> > This patchset is a rebased version of David's sched timehist work [1].
> > I plan to improve perf sched command more and think that having
> > timehist command before the work looks good.  It seems David is busy
> > these days, so I'm retrying it by myself.
> > 
> >  * changes in v2)
> >   - change name 'b/n time' to 'wait time'  (Ingo)
> >   - show arrow between functions in the callchain  (Ingo)
> >   - fix a bug in calculating initial run time
> 
> you might want to add some column width cuts.. I've got this:

The task name column width is initially set to 20, and grow
dynamically when longer name + tid/pid is found.  Maybe I need to
change it to have the max width initially.. (in later patch).

> 
>            time    cpu  task name             wait time  sch delay   run time
>                         [tid/pid]                (msec)     (msec)     (msec)
> --------------- ------  --------------------  ---------  ---------  ---------
>   482381.387934 [0000]  perf[6870]                0.000      0.000      0.000 
>   482381.388838 [0002]  <idle>                    0.000      0.000      0.000 
>   482381.388845 [0002]  plugin-containe[25990/25970]      0.000      0.004      0.007 
>   482381.388897 [0003]  <idle>                            0.000      0.000      0.000 
>   482381.388919 [0002]  <idle>                            0.007      0.000      0.074 
>   482381.388925 [0003]  Timer[15210/15178]                0.000      0.002      0.027 
> 
> 
> 
> other than that:
> 
> Acked-by: Jiri Olsa <jolsa@redhat.com>

Thanks,
Namhyung