From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755374AbcKVICe (ORCPT ); Tue, 22 Nov 2016 03:02:34 -0500 Received: from mga14.intel.com ([192.55.52.115]:27656 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752817AbcKVICc (ORCPT ); Tue, 22 Nov 2016 03:02:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,680,1473145200"; d="scan'208";a="194354185" Date: Tue, 22 Nov 2016 09:58:13 +0200 From: Heikki Krogerus To: Greg KH Cc: Guenter Roeck , Badhri Jagan Sridharan , Oliver Neukum , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCHv11 2/3] usb: USB Type-C connector class Message-ID: <20161122075813.GD18501@kuha.fi.intel.com> References: <20161117105036.133406-1-heikki.krogerus@linux.intel.com> <20161117105036.133406-3-heikki.krogerus@linux.intel.com> <20161121103311.GA2233@kroah.com> <20161121132741.GB18501@kuha.fi.intel.com> <20161121144608.GB28410@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161121144608.GB28410@kroah.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On Mon, Nov 21, 2016 at 03:46:08PM +0100, Greg KH wrote: > > > > + > > > > +config TYPEC > > > > + tristate > > > > > > Hah, that says NOTHING about what this code is at all. > > > > Alone the class driver does nothing. Why would the user need to be > > aware of if it when selecting the Type-C drivers, and what can the > > user use that information for? > > If you see a blank Kconfig option, what are you supposed to do with it? > How do you know if you need to enable it or not? Are you just supposed > to guess? But you don't see anything when you are selecting the drivers and that is the point. You now can't select this separately. There is now no option for it. Why should we bother the user with this? The user is most likely only interested in the drivers and by selecting those the user will get the interface. The drivers will need to have the dependency to the class set correctly in any case. Thanks, -- heikki