From: Wolfram Sang <wsa-dev@sang-engineering.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH v5 6/6] i2c: use an IRQ to report Host Notify events, not alert
Date: Tue, 22 Nov 2016 12:49:22 +0100 [thread overview]
Message-ID: <20161122114922.GA3993@katana> (raw)
In-Reply-To: <20161121105248.GH2119@mail.corp.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
On Mon, Nov 21, 2016 at 11:52:48AM +0100, Benjamin Tissoires wrote:
> Hi Wolfram,
>
> On Nov 07 2016 or thereabouts, Wolfram Sang wrote:
> > On Thu, Oct 13, 2016 at 02:10:40PM +0200, Benjamin Tissoires wrote:
> > > The current SMBus Host Notify implementation relies on .alert() to
> > > relay its notifications. However, the use cases where SMBus Host
> > > Notify is needed currently is to signal data ready on touchpads.
> > >
> > > This is closer to an IRQ than a custom API through .alert().
> > > Given that the 2 touchpad manufacturers (Synaptics and Elan) that
> > > use SMBus Host Notify don't put any data in the SMBus payload, the
> > > concept actually matches one to one.
> >
> > I see the advantages. The only question I have: What if we encounter
> > devices in the future which do put data in the payload? Can this
> > mechanism be extended to handle that?
>
> I guess I haven't convinced you with my answer. Is there anything I can
> do to get this series in v4.10 or do you prefer waiting for v4.11?
I consider this v4.10 material. I was thinking a little about how to not
lose data with consecutive interrupts but then -EBUSY came along.
Nonetheless, it looks to me like the proper path to follow...
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-11-22 11:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 12:10 [PATCH v5 0/6] i2c: Host Notify / i801 fixes Benjamin Tissoires
2016-10-13 12:10 ` [PATCH v5 1/6] i2c: i801: store and restore the SLVCMD register at load and unload Benjamin Tissoires
2016-10-13 12:10 ` [PATCH v5 2/6] i2c: i801: minor formatting issues Benjamin Tissoires
2016-10-13 12:10 ` [PATCH v5 3/6] i2c: i801: use BIT() macro for bits definition Benjamin Tissoires
2016-10-13 12:10 ` [PATCH v5 4/6] i2c: i801: use the BIT() macro for FEATURES_* also Benjamin Tissoires
2016-10-13 12:10 ` [PATCH v5 5/6] i2c: i801: remove SMBNTFDDAT reads as they always seem to return 0 Benjamin Tissoires
2016-10-13 12:10 ` [PATCH v5 6/6] i2c: use an IRQ to report Host Notify events, not alert Benjamin Tissoires
2016-11-07 0:20 ` Wolfram Sang
2016-11-07 16:18 ` Benjamin Tissoires
2016-11-21 10:52 ` Benjamin Tissoires
2016-11-22 11:49 ` Wolfram Sang [this message]
2016-11-24 15:06 ` Wolfram Sang
2016-11-24 15:10 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122114922.GA3993@katana \
--to=wsa-dev@sang-engineering.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).