linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <thierry.reding@gmail.com>, <lee.jones@linaro.org>
Cc: <tomi.valkeinen@ti.com>, <linux-pwm@vger.kernel.org>,
	<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<p.zabel@pengutronix.de>
Subject: [PATCH v4 0/2] backlight: pwm_bl: Fix the initial power state selection
Date: Tue, 22 Nov 2016 15:41:21 +0200	[thread overview]
Message-ID: <20161122134123.1209-1-peter.ujfalusi@ti.com> (raw)

Hi,

Changes since v3:
- Change 'pwm' to 'PWM' in comments and commit message
- Extended the comment before we change the GPIO direction and state in case it
  was set as input initially.
- Acked/Review-by added from Philipp and Thierry

Changes since v2:
- Do not change the way how the GPIO initially configured as input is handled.
  Configure it as output and set it's state as active.

Changes since v1:
- Handling of the enable GPIO is reworked:
 - Only change direction to output when the pin was input and in this case set
   the GPIO line physical low
 - With this change we can ensure that the enable GPIO is output so we do not
   need to check the direction of it later on.

Cover letter:

3698d7e7d221 backlight: pwm_bl: Avoid backlight flicker when probed from DT

added support for avoiding backlight flickering, which in essence was designed
to not enable the baclkight when the driver loads, but let the user of the
backlight to enable it later on.

There are boards (like am437x-gp-evm) where we do not have valid GPIO to enable
the backlight (TPS61081DRC's EN pin is connected to V3_3D) and the regulator
is always on (VBAT in case of the gp-evm). In this board the logic to check the
GPIO state and the regulator is failing and the backlight will be enabled as
soon as the pwm_bl driver is loaded.

By extending the check to look at the PWM state this issue can be avoided and
the backlight will be enabled only when it's user is asking it to be enabled.

Regards,
Peter
---
Peter Ujfalusi (2):
  backlight: pwm_bl: Move the checks for initial power state to a
    separate function
  backlight: pwm_bl: Check the PWM state for initial backlight power
    state

 drivers/video/backlight/pwm_bl.c | 60 +++++++++++++++++++++++++++-------------
 1 file changed, 41 insertions(+), 19 deletions(-)

-- 
2.11.0.rc2

             reply	other threads:[~2016-11-22 13:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 13:41 Peter Ujfalusi [this message]
2016-11-22 13:41 ` [PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function Peter Ujfalusi
2016-12-09  9:13   ` Lee Jones
2017-03-21 18:48   ` Geert Uytterhoeven
2017-03-22 10:46     ` Philipp Zabel
2017-03-22 12:30       ` Geert Uytterhoeven
2016-11-22 13:41 ` [PATCH v4 2/2] backlight: pwm_bl: Check the PWM state for initial backlight power state Peter Ujfalusi
2016-12-09  9:14   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161122134123.1209-1-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).