linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Kevin Hilman <khilman@baylibre.com>,
	Rob Herring <robh@kernel.org>, Rafael Wysocki <rjw@rjwysocki.net>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Lina Iyer <lina.iyer@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Nayak Rajendra <rnayak@codeaurora.org>
Subject: Re: [PATCH 1/2] PM / Domains: Introduce domain-performance-state binding
Date: Wed, 23 Nov 2016 08:52:18 +0530	[thread overview]
Message-ID: <20161123032218.GA22335@vireshk-i7> (raw)
In-Reply-To: <CAKfTPtDR6Y5UgaqJ+D5T0yBeFRSYWm6OT1+r4ZABrtqtvF2D0w@mail.gmail.com>

Thanks for explaining on my behalf Vincent :)

On 22-11-16, 19:34, Vincent Guittot wrote:
> On 22 November 2016 at 19:12, Kevin Hilman <khilman@baylibre.com> wrote:
> > I think the question is: what does the performance-level of a domain
> > actually mean?  Or, what are the units?

There is no unit. If we have units like Hz and volts etc, then we can actually
use the existing clk/regulator frameworks straight away.

The whole problem here is that the regulator (and maybe the clock on a different
platform) for a power domain are hidden from the kernel and handled by a black
box (An M3 core in my case). All we can ask is for a performance state, a simple
positive integer value.

> > Depending on the SoC, there's probably a few things this could mean.  It
> > might mean is that an underlying bus/interconnect can be configured to
> > guarantee a specific bandwidth or throughput.

We are talking in terms of power domains here and so if the bus/interconnect has
a power domain for itself, then yes we can very much have that situation. But if
the kernel have the capability of configuring clk and voltages directly, then we
don't need this new infrastructure at all.

> > That in turn might mean
> > that that bus/interconnect might have to be set at a specific
> > frequency/voltage.
> >
> > In your case, IIUC, you're just passing some magic value to some
> > firmware running on a micro-controller, but under the hood that uC is
> > probably configuring a frequency/voltage someplace.
> 
> In the case described by Viresh, it's only about setting the voltage
> of a power domain that is shared between different devices. these
> devices wants to run at different frequency (set by the devices) but
> we have to select a Volateg value that will match with the constraint
> of all devices (in this case the highest voltage)

That's right.

> > So, if we're going to have a generic DT binding for this, it needs to be
> > something that's useful on platforms that are not using magic numbers
> > managed by a uC as well.

What suggestions do you have for this and I am not sure what all cases we want
to solve by this ?

-- 
viresh

  reply	other threads:[~2016-11-23  3:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  9:23 [PATCH 0/2] PM / Domains / OPP: Introduce domain-performance-state binding Viresh Kumar
2016-11-18  9:23 ` [PATCH 1/2] PM / Domains: " Viresh Kumar
2016-11-21 15:07   ` Rob Herring
2016-11-22  3:17     ` Viresh Kumar
2016-11-22 18:12       ` Kevin Hilman
2016-11-22 18:34         ` Vincent Guittot
2016-11-23  3:22           ` Viresh Kumar [this message]
2016-11-23 15:51           ` Kevin Hilman
2016-11-23 15:55             ` Vincent Guittot
2016-11-23 22:30               ` Kevin Hilman
2016-11-24  2:03                 ` Stephen Boyd
2016-11-24  4:40                   ` Viresh Kumar
2016-11-28 18:27                     ` Stephen Boyd
2016-11-29  6:57                       ` Viresh Kumar
2016-11-30  1:08                         ` Stephen Boyd
2016-12-02 10:47                           ` Viresh Kumar
2016-11-18  9:23 ` [PATCH 2/2] PM / OPP: Introduce domain-performance-state binding to OPP nodes Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161123032218.GA22335@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=lina.iyer@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=rnayak@codeaurora.org \
    --cc=robh@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).