From: alexander.levin@verizon.com
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"scientist@fb.com" <scientist@fb.com>,
"glider@google.com" <glider@google.com>,
"andreyknvl@google.com" <andreyknvl@google.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"mathieu.desnoyers@efficios.com" <mathieu.desnoyers@efficios.com>,
"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 2/3] abi_spec: hooks into syscall to allow pre and post checking
Date: Wed, 23 Nov 2016 15:04:27 +0000 [thread overview]
Message-ID: <20161123150435.GA30459@sasha-lappy> (raw)
In-Reply-To: <CACT4Y+YVqFv6hkr+rdoJarS0mx=_eLGaCP1WjgyPH+rpL69yMw@mail.gmail.com>
On Mon, Nov 21, 2016 at 04:57:02PM +0100, Dmitry Vyukov wrote:
> On Mon, Nov 21, 2016 at 4:54 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Wed, 16 Nov 2016 17:37:01 +0000
> > alexander.levin@verizon.com wrote:
> >> #define __SYSCALL_DEFINEx(x, name, ...) \
> >> + extern const struct syscall_spec syscall_spec##name; \
> >> asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \
> >> __attribute__((alias(__stringify(SyS##name)))); \
> >> static inline long SYSC##name(__MAP(x,__SC_DECL,__VA_ARGS__)); \
> >> asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)); \
> >> asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \
> >> { \
> >> - long ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \
> >> + long ret; \
> >> + abispec_check_pre(&syscall_spec##name, __MAP(x,__SC_CAST,__VA_ARGS__)); \
> >> + ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \
> >> + abispec_check_post(&syscall_spec##name, ret, __MAP(x,__SC_CAST,__VA_ARGS__)); \
> >
> > Do you want this for DEFINE0() too? Or does this not care about system
> > calls with no arguments?
>
> This should care about syscalls without args:
> - we still may want to check return values
> - something like debug tracing would like to print them
> - there may also be some side effects (or absence of side effects)
> that we may want to check
Yes, agreed, I just missed that detail in my implementation.
--
Thanks,
Sasha
next prev parent reply other threads:[~2016-11-23 15:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 17:37 [RFC 0/3] ABI spec - verification alexander.levin
2016-11-16 17:37 ` [RFC 1/3] abi_spec: basic definitions of constraints, args and syscalls alexander.levin
2016-11-21 14:48 ` Dmitry Vyukov
2016-11-23 14:59 ` alexander.levin
2016-12-12 10:29 ` Dmitry Vyukov
2016-12-12 10:45 ` Dmitry Vyukov
2016-12-14 19:46 ` Dmitry Vyukov
2016-12-14 19:48 ` Dmitry Vyukov
2017-01-04 4:52 ` alexander.levin
2016-12-27 17:23 ` alexander.levin
2016-12-28 7:32 ` Dmitry Vyukov
2016-11-21 15:41 ` Steven Rostedt
2016-11-23 15:03 ` alexander.levin
2016-11-23 15:31 ` Steven Rostedt
2016-11-23 15:33 ` Steven Rostedt
2016-11-16 17:37 ` [RFC 2/3] abi_spec: hooks into syscall to allow pre and post checking alexander.levin
2016-11-21 15:54 ` Steven Rostedt
2016-11-21 15:57 ` Dmitry Vyukov
2016-11-23 15:04 ` alexander.levin [this message]
2016-11-16 17:37 ` [RFC 3/3] abi_spec: example spec for open(), placeholder for rest of syscalls alexander.levin
2016-11-16 17:46 ` [RFC 0/3] ABI spec - verification Thomas Gleixner
2016-11-21 14:25 ` Dmitry Vyukov
2016-11-23 14:36 ` alexander.levin
2016-12-12 10:12 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123150435.GA30459@sasha-lappy \
--to=alexander.levin@verizon.com \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
--cc=scientist@fb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).