From: Adam Borowski <kilobyte@angband.pl>
To: "Manuel Schölling" <manuel.schoelling@gmx.de>
Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, jslaby@suse.cz,
gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, andrey_utkin@fastmail.com
Subject: Re: [PATCH v5 2/2] console: Add persistent scrollback buffers for all VGA consoles
Date: Wed, 23 Nov 2016 18:33:40 +0100 [thread overview]
Message-ID: <20161123173340.GA24872@angband.pl> (raw)
In-Reply-To: <1479833802.19820.8.camel@gmx.de>
On Tue, Nov 22, 2016 at 05:56:42PM +0100, Manuel Schölling wrote:
> On Mo, 2016-11-21 at 21:17 +0100, Adam Borowski wrote:
> > On Sun, Nov 20, 2016 at 10:58:08PM +0100, Manuel Schölling wrote:
> > > Add a scrollback buffers for each VGA console. The benefit is that
> > > the scrollback history is not flushed when switching between consoles
> > > but is persistent.
>
> > But alas, this commit breaks that very \e[3J. It does only a \e[2J, leaving
> > the scrollback uncleared. For comparison, both mainline and with just your
> > preparatory commit, \e[3J works as expected.
> Really? All my tests worked fine: I compiled the kernel with the latest patches, started the kernel in QEMU and then did
>
> $ openvt /bin/sh
> $ echo -e '\e[3J' # scrollback buffer was flushed correctly
> $ chvt 2
> $ echo -e '\e[3J' # scrollback buffer was flushed correctly
>
> Can you tell me how you tested it? Maybe I can reproduce the bug.
(Re-tested on v6 of the patch.)
On bare metal: boot, log in on tty1, printf '\e[3J', screen clears but when
I scroll back, it still has bootup messages. Switching to another tty then
back obviously doesn't clear it either. Same on any other tty (after
putting something into the scrollback of). Graphics card is nvidia GT240,
neither proprietary driver nor nouveau loaded; nouveau forces fbdev and your
patch is vgacon specific (hopefully just for now).
But then, I just reproduced this on qemu (-vga qxl) too, so it might be due
to a difference between our setups somehow. In case it's something related
to .config, mine's at https://angband.pl/tmp/config-4.9.0-rc6-debug2+.xz
Meow!
--
An imaginary friend squared is a real enemy.
next prev parent reply other threads:[~2016-11-23 17:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161118005309.GC26324@dell-m4800.home>
2016-11-20 21:58 ` [PATCH v5 0/2] console: Add persistent scrollback buffers for all VGA console Manuel Schölling
2016-11-20 21:58 ` [PATCH v5 1/2] console: Move scrollback data into its own struct Manuel Schölling
2016-11-20 21:58 ` [PATCH v5 2/2] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling
2016-11-20 22:23 ` kbuild test robot
2016-11-21 20:17 ` Adam Borowski
2016-11-22 16:56 ` Manuel Schölling
2016-11-23 17:33 ` Adam Borowski [this message]
2016-11-27 16:51 ` [PATCH v7 0/3] " Manuel Schölling
2016-11-27 16:51 ` [PATCH v7 1/3] console: Move scrollback data into its own struct Manuel Schölling
2016-11-27 16:51 ` [PATCH v7 2/3] console: Add callback to flush scrollback buffer to consw struct Manuel Schölling
2016-11-27 16:51 ` [PATCH v7 3/3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling
2016-11-27 21:37 ` [PATCH v7 0/3] " Andrey Utkin
2016-11-27 23:15 ` Adam Borowski
2016-11-27 23:30 ` Jakub Wilk
2016-11-28 0:02 ` Andrey Utkin
2016-11-28 21:28 ` Manuel Schölling
2016-11-29 10:01 ` Andrey Utkin
2016-11-29 10:44 ` Adam Borowski
2016-11-29 16:35 ` Manuel Schölling
2016-12-01 21:03 ` Manuel Schölling
2016-12-01 21:31 ` Andrey Utkin
2016-11-27 23:53 ` Adam Borowski
2016-11-28 21:23 ` Manuel Schölling
2016-11-23 17:33 ` [PATCH v5 2/2] " Manuel Schölling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123173340.GA24872@angband.pl \
--to=kilobyte@angband.pl \
--cc=andrey_utkin@fastmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.schoelling@gmx.de \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).