From: Thierry Reding <thierry.reding@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Suresh Mangipudi <smangipudi@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] gpio: Add Tegra186 support
Date: Wed, 23 Nov 2016 20:44:23 +0100 [thread overview]
Message-ID: <20161123194423.GA26733@ulmo.ba.sec> (raw)
In-Reply-To: <CACRpkdYs3WoBPCiuuuka_DQz5KP0Sxc_wT57Zd3c4MF+9xH1+Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]
On Wed, Nov 23, 2016 at 02:30:45PM +0100, Linus Walleij wrote:
> On Tue, Nov 22, 2016 at 6:55 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
>
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Tegra186 has two GPIO controllers that are largely register compatible
> > between one another but are completely different from the controller
> > found on earlier generations.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> I would prefer if you could try to convert this driver to use
> CONFIG_GPIOLIB_IRQCHIP and install a chained interrupt
> handler with gpiochip_irqchio_add() + gpiolib_set_chained_irqchip().
> It would save us so much trouble and so much complicated
> code to maintain for this custom irqdomain.
>
> I suggest you to look into the mechanisms mentioned in my
> previous mail for how to poke holes in the single linear
> irqdomain used by this mechanism.
>
> As it seems, you only have one parent interrupt with all
> these IRQs cascading off it as far as I can tell.
Like I said in other email, I don't think this will work because the
GPIOLIB_IRQCHIP support seems to be limited to cases where a single
parent interrupt is used. We could possibly live with a single IRQ
handler and data, but we definitely need to request multiple IRQs if
we want to be able to use all GPIOs as interrupts.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-11-23 19:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 10:48 [PATCH] gpio: tegra186: Add support for T186 GPIO Suresh Mangipudi
2016-11-07 7:53 ` Linus Walleij
2016-11-07 13:21 ` Thierry Reding
2016-11-08 1:42 ` Olof Johansson
2016-11-08 15:55 ` Thierry Reding
2016-11-08 16:49 ` Stephen Warren
2016-11-08 17:58 ` Thierry Reding
2016-11-08 19:07 ` Stephen Warren
2016-11-22 17:30 ` Thierry Reding
2016-11-22 17:55 ` [PATCH] gpio: Add Tegra186 support Thierry Reding
2016-11-23 13:30 ` Linus Walleij
2016-11-23 19:44 ` Thierry Reding [this message]
2016-11-24 15:40 ` Linus Walleij
2016-11-24 6:53 ` Laxman Dewangan
2016-11-24 14:44 ` Thierry Reding
2016-11-24 14:44 ` Laxman Dewangan
2016-11-24 15:08 ` Thierry Reding
2016-11-25 12:10 ` Laxman Dewangan
2016-11-23 13:25 ` [PATCH] gpio: tegra186: Add support for T186 GPIO Linus Walleij
2016-11-23 19:40 ` Thierry Reding
2016-11-24 6:36 ` Laxman Dewangan
2016-11-24 15:01 ` Thierry Reding
2016-11-24 15:08 ` Linus Walleij
2016-11-24 16:32 ` Thierry Reding
2016-11-24 23:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123194423.GA26733@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=smangipudi@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).